Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per request rate limiting to carbonzipper #12

Open
dgryski opened this issue Sep 25, 2014 · 4 comments
Open

Per request rate limiting to carbonzipper #12

dgryski opened this issue Sep 25, 2014 · 4 comments
Milestone

Comments

@dgryski
Copy link
Member

dgryski commented Sep 25, 2014

This will throttle bulk-style requests, but not adversely affect smaller API calls from proceding.

Requires a bit more thinking to figure out if this is a problem and if this is the best solution.

@nnuss
Copy link
Collaborator

nnuss commented Aug 28, 2016

This is nearly 2 years old - think we should still look at it?

@dgryski
Copy link
Member Author

dgryski commented Aug 28, 2016

There were two issues I wanted to solve with this:

  1. limiting the number of HTTP connections that were made to the local zipper
  2. limiting the "burstiness" of a massive query, since that will overload the pipeline

The first issue will be solved with go-graphite/carbonzipper#16 (moving to grpc).
The second one still needs to be considered.

@nnuss
Copy link
Collaborator

nnuss commented Aug 28, 2016

Re: 2) Graphite has moved to a single-phase /render request to the backing stores.
If we also make that change as well as carbonserver support for multiple target:
/render/?from=147...&to=147...&format=...&target=metric.a&target=metric.b&target=...
; do you think that could make substantial improvements to the connection "burstiness"?
[Realize I'm suggesting something with its own performance implications.]

@dgryski
Copy link
Member Author

dgryski commented Aug 29, 2016

Everything in the stack currently supports the single /render/ request. It works with globs, not multiple targets though.

@Civil Civil added this to the 1.0 milestone Apr 26, 2017
gksinghjsr added a commit to gksinghjsr/carbonapi that referenced this issue Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants