Skip to content

Service Not Running When Running 1.23.1 for Update from 1.22.6 to 1.23.1 in Windows OS #33235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jang-Haemin opened this issue Jan 13, 2025 · 11 comments · Fixed by #33463
Closed
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail type/bug
Milestone

Comments

@Jang-Haemin
Copy link

Description

Hello?
This is a user who installs and uses Gitea on the company's Windows OS server.
I'm running Gitea as a Windows service, and I've enabled https using ACME.

Currently, the version of our instance is 1.22.6 and is running using the gitea-1.22.6-gogit-window-4.0-amd64.exe file.
The size of this file is 210mb.
Please remember the size of this file.

I downloaded the gitea-1.23.1-gogit-window-4.0-amd64.exe file and ran it as a service, as I had previously updated.
However, the service fails to run, and nothing is recorded in the gitea.log.
Instead, Windows Event Viewer experiences an error with the attachment.

The file size of the updated 1.23.1 version is 113mb, which is nearly 100mb smaller than before.
Is there an execution problem because there is a missing file due to this update?
Or is there anything else I need to work on as it gets updated from 1.22.6 to 1.23?

I entered it using a translator, so the content may be awkward.
Thank you for reading, and I would appreciate it if you could let me know how I can solve this problem.

Gitea Version

1.23.1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

1.22.6

Operating System

Windows Server 2019 v17763.6659

How are you running Gitea?

Download the gitea-version-gogit-window-4.0-amd64.exe file and run it as a Windows service.

Database

SQLite

@lunny
Copy link
Member

lunny commented Jan 13, 2025

The binary reduction is by design because we removed some unused packages and some new build parameters have ben enabled.

Can you run gitea web in a command line and get some errors log?

@lunny lunny added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Jan 13, 2025
@Jang-Haemin
Copy link
Author

이진 감소는 일부 사용되지 않는 패키지를 제거하고 일부 새로운 빌드 매개변수를 활성화했기 때문에 의도적으로 수행되었습니다.

명령줄에서 실행해서 gitea web오류 로그를 얻을 수 있나요?

cmd_result

When I run the command as you said, I get an error like below.

...ules/setting/time.go:21:loadTimeFrom() [F] Load time zone failed: unknown time zone Asia/Shanghai

The locale of the PC running gitea is Korean, and I wanted to use the time appropriate for Korea, so I specified the following in the app.ini file.

[time]
DEFAULT_UI_LOCATION = Asia/Shanghai

@lunny
Copy link
Member

lunny commented Jan 13, 2025

Can you try changing Asia/Shanghai to Asia/Seoul?

@wxiaoguang
Copy link
Contributor

The locale of the PC running gitea is Korean, and I wanted to use the time appropriate for Korea, so I specified the following in the app.ini file.

You can leave it empty then it should use OS's timezone IIRC

@Jang-Haemin
Copy link
Author

Jang-Haemin commented Jan 13, 2025

Thank you for your quick response.
The symptoms were the same even when I changed to Asia/Seoul.

However, as wxiaoguang said, I removed the DEFAULT_UI_LOCATION property and it works well.

We hope this will be fixed for users who want to specify a timezone.
Thank you all.

@lunny
Copy link
Member

lunny commented Jan 13, 2025

Thank you for your quick response. The symptoms were the same even when I changed to Asia/Seoul.

However, as wxiaoguang said, I removed the DEFAULT_UI_LOCATION property and it works well.

We hope this will be fixed for users who want to specify a timezone. Thank you all.

I think it depends on your system, maybe there is no zoneinfo data for those time locations.

@Jang-Haemin
Copy link
Author

I see. The odd thing is that it worked fine before version 1.22.6.

@wxiaoguang
Copy link
Contributor

Maybe it's related to the build.

The timezone info should be packed into the binary. But maybe the new build misses that? @techknowlogick

@wxiaoguang wxiaoguang reopened this Jan 14, 2025
@wxiaoguang
Copy link
Contributor

Maybe it's related to the build.

The timezone info should be packed into the binary. But maybe the new build misses that? @techknowlogick

@techknowlogick is it related?

@wxiaoguang
Copy link
Contributor

Maybe it's related to the build.
The timezone info should be packed into the binary. But maybe the new build misses that? @techknowlogick

@techknowlogick is it related?

@techknowlogick is it related?

@techknowlogick
Copy link
Member

@wxiaoguang looking at the workflows, it seems they have not included the additional build tag for sometime (if at all), but to align with the docker image tags I added the tz tag to the binary release files too #33463 as even if it doesn't help with this issue, it at least ensures a consistent binary between docker and non-docker.

@lunny lunny added this to the 1.23.2 milestone Feb 5, 2025
@wxiaoguang wxiaoguang linked a pull request Feb 5, 2025 that will close this issue
lunny pushed a commit that referenced this issue Feb 5, 2025
`timetzdata` is already used in the docker images, this includes them
for the binary release files too.

Related to #33235 (I don't have a windows machine setup to test this
though)

---------

Co-authored-by: wxiaoguang <[email protected]>
lunny pushed a commit to lunny/gitea that referenced this issue Feb 5, 2025
`timetzdata` is already used in the docker images, this includes them
for the binary release files too.

Related to go-gitea#33235 (I don't have a windows machine setup to test this
though)

---------

Co-authored-by: wxiaoguang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants