Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It should be possible to use a label or device name for a mount in the image partition action #409

Open
martin-petzold opened this issue Jun 4, 2023 · 4 comments

Comments

@martin-petzold
Copy link

Currently debos uses UUIDs for the /etc/fstab entries. However, in some cases when using an A/B system upgrade machanism this can lead to the problem that partitions can't be mounted on boot. See related issue for RAUC: rauc/rauc#1149

The image partition action should have an option to use either the label (LABEL=...) or the device name for the specific entry in the /etc/fstab.

@obbardc
Copy link
Member

obbardc commented Jun 8, 2023

completly agree; currently we workaround this by not autogenerating /etc/fstab then manually creating it e.g.

 - action: filesystem-deploy
   setup-fstab: false
  - action: run
    description: Create fstab
    command: echo "PARTLABEL=system	/	ext4	defaults,rw	0	0" > ${ROOTDIR}/etc/fstab

We could extend the filesystem-deploy action somewhat to add addtional properties. This could be something like fstab-mount-by: label with uuid as the default (current case).

@martin-petzold
Copy link
Author

But if "filesystem-deploy" is already executed, how can then the fstab file be created in ${ROOTDIR}?
Maybe you mean the other way round?

I would suggest to add the property to the image-partition action. The mountpoints are defined in image-partition and should be customized using other than UUID, e.g.

    mountpoints:
      - mountpoint: /
        partition: rootfs0
        identifier: [uuid|label|device]

@martin-petzold
Copy link
Author

Also it would be good, if mountpoints would support bind mounts.

@obbardc
Copy link
Member

obbardc commented Jul 17, 2023

@martin-petzold please open a separate issue for bind mount support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants