You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
How about going further: instead of just making this a option, how about we make it the default behavior of toml set?
I feel like for most use cases, you're always going to want to write the edited file back. So it'd be cleaner if you could say simply toml set foo.toml …, rather than saying toml set --overwrite (or whatever we might call this option) all the time.
That would also make it align better with the name "set" than it currently does.
We can always include an option to go back to the other behavior, with a name like --dry-run or --print.
(Yes, this is an incompatible change. But as the README says:
The command's status is experimental. The current interface does not yet serve its purposes as well as it could, and incompatible changes are anticipated.
Making toml set update the actual file on disk is exactly the sort of change I had in mind with that warning.)
The text was updated successfully, but these errors were encountered:
Let's actually fold this one into the discussion on the existing issue thread #7 -- I think that'll be the best home for it. In particular that way the folks on that thread will see the discussion.
Originally posted by @gnprice in #13 (comment):
How about going further: instead of just making this a option, how about we make it the default behavior of
toml set
?I feel like for most use cases, you're always going to want to write the edited file back. So it'd be cleaner if you could say simply
toml set foo.toml …
, rather than sayingtoml set --overwrite
(or whatever we might call this option) all the time.That would also make it align better with the name "set" than it currently does.
We can always include an option to go back to the other behavior, with a name like
--dry-run
or--print
.(Yes, this is an incompatible change. But as the README says:
Making
toml set
update the actual file on disk is exactly the sort of change I had in mind with that warning.)The text was updated successfully, but these errors were encountered: