Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint and Format codebase #143

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Lint and Format codebase #143

merged 6 commits into from
Oct 31, 2023

Conversation

cristovaoth
Copy link
Contributor

This PR:

  • bumps some tooling dependencies (expect hardhat and ethers)
  • applies formatting to the codebase
  • fixes linting errors

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 6708090779

  • 121 of 122 (99.18%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.02%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/core/Modifier.sol 44 45 97.78%
Totals Coverage Status
Change from base Build 6691256976: 0.0%
Covered Lines: 121
Relevant Lines: 122
💛 - Coveralls

auryn-macmillan
auryn-macmillan approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@auryn-macmillan auryn-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cristovaoth cristovaoth merged commit c169eb7 into master Oct 31, 2023
2 checks passed
@cristovaoth cristovaoth deleted the lint-format-fix branch October 31, 2023 15:02
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
auryn-macmillan
auryn-macmillan reviewed Oct 31, 2023
View reviewed changes
contracts/core/Modifier.sol
modules[module] = modules[SENTINEL_MODULES];
modules[SENTINEL_MODULES] = module;
emit EnabledModule(module);
return address(0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we touch this line in the unit tests to get 100% coverage?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@auryn-macmillan auryn-macmillan auryn-macmillan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristovaoth @auryn-macmillan