Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🔥A1] Modifier.sol Transactions with EIP-712 and EIP-1271 Signature Authentication #137

Merged
merged 41 commits into from
Oct 27, 2023
Merged

[🔥A1] Modifier.sol Transactions with EIP-712 and EIP-1271 Signature Authentication #137

merged 41 commits into from
Oct 27, 2023

Commits on Oct 26, 2023

  1. First crack at the base class that does the EIP712 appended signature… 

    … split and extraction
    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    5d288d7 View commit details
    Browse the repository at this point in the history

  2. Include EIP712 signature auth logic into Modifier.sol, 

    This new module auth mode is backwards compatible, and transparent with respect to current module ABIs
    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    868ce59 View commit details
    Browse the repository at this point in the history

  3. Add tests ensuring Modifier is managing nonce correctly

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    e975b8d View commit details
    Browse the repository at this point in the history

  4. Naming improvements

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    df35063 View commit details
    Browse the repository at this point in the history

  5. Use block.chainid instead of opening an assembley block

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    3f71d04 View commit details
    Browse the repository at this point in the history

  6. Move moduleOnly only to more straigthforward shape

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    4ac7bd7 View commit details
    Browse the repository at this point in the history

  7. Signer should not define the relayer's message value.

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    f45187e View commit details
    Browse the repository at this point in the history

  8. Rename root type for EIP712 data structure

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    f6d7d08 View commit details
    Browse the repository at this point in the history

  9. Add natspec

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    2b30406 View commit details
    Browse the repository at this point in the history

  10. Extract badSignature checks to their own test cases, instead of mixed… 

    … with success case tests
    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    72b4f25 View commit details
    Browse the repository at this point in the history

  11. Rename helper function

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    12b96e5 View commit details
    Browse the repository at this point in the history

  12. Renames in preparation for eip-1271 signatures

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    cd85276 View commit details
    Browse the repository at this point in the history

  13. Add eip-1271 support

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    148fb8a View commit details
    Browse the repository at this point in the history

  14. Rename helper function

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    300c80a View commit details
    Browse the repository at this point in the history

  15. Change visibility of moduleTxHash. Comments

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    557e372 View commit details
    Browse the repository at this point in the history

  16. Update comments. Use v,s,r order. Add test cases

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    09cdbb2 View commit details
    Browse the repository at this point in the history

  17. Adjust comments

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    e10e352 View commit details
    Browse the repository at this point in the history

  18. Adjust comments

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    d05f894 View commit details
    Browse the repository at this point in the history

  19. Introduce GuardableModule and GuardableModifier - this makes Module a… 

    …nd Modifier leaner by default
    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    7c6c8ef View commit details
    Browse the repository at this point in the history

  20. GuardableModifier tests

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    446cd08 View commit details
    Browse the repository at this point in the history

  21. Bumping OpenZeppeling for bytecode optimized base classes

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    cc0e322 View commit details
    Browse the repository at this point in the history

  22. remove import

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    f098f7d View commit details
    Browse the repository at this point in the history

  23. Mark exec functions as virtual for Guardable*

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    2cf6cda View commit details
    Browse the repository at this point in the history

  24. Prettier

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    d2a122d View commit details
    Browse the repository at this point in the history

  25. Make execTransactionFromModule virtual

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    022394c View commit details
    Browse the repository at this point in the history

  26. Add comment to Modifier.sol

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    fc032b7 View commit details
    Browse the repository at this point in the history

  27. Break down Modifier authorization logic in reusable parts

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    7960593 View commit details
    Browse the repository at this point in the history

  28. Add failing tests

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    9093ce3 View commit details
    Browse the repository at this point in the history

  29. Changing the base SignatureChecker to work with user proposed salt, i… 

    …nstead of self managed nonce
    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    9aaae1b View commit details
    Browse the repository at this point in the history

  30. Introduce execution tracking into Modifier.sol based on executed and … 

    …invalidated hashes
    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    ea645eb View commit details
    Browse the repository at this point in the history

  31. Rename auxiliary function

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    dd9e84c View commit details
    Browse the repository at this point in the history

  32. Moving the newly introducedd errors into ExecutionTracker

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    908adeb View commit details
    Browse the repository at this point in the history

  33. Fully cover guard with tests

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    cd40d32 View commit details
    Browse the repository at this point in the history

  34. Make sentOrSigned by an internal helper function for Modifiers

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    91d32ee View commit details
    Browse the repository at this point in the history

  35. Make moduleTxSignedBy return always the hash, even when no signer fou… 

    …nd recovered
    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    c4211a4 View commit details
    Browse the repository at this point in the history

  36. Consolidate hash tracking into one mapping

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    41f16eb View commit details
    Browse the repository at this point in the history

  37. Ensure contract specific signature is sliced correctly

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    9c1306e View commit details
    Browse the repository at this point in the history

  38. Simplify splitSignature, and pull up logic that assembles the isValid… 

    …ContractSignature call
    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    637dcf1 View commit details
    Browse the repository at this point in the history

  39. Add test for contract specific signature empty

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    64971c5 View commit details
    Browse the repository at this point in the history

  40. Remove aux variable

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    9f65e4d View commit details
    Browse the repository at this point in the history

  41. Consistently return hash from moduleTxSignedBy()

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    267725a View commit details
    Browse the repository at this point in the history