Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect typecast to zero bytes #129

Merged
merged 3 commits into from
Jul 24, 2023
Merged

fix: incorrect typecast to zero bytes #129

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf70414
fix: incorrect typecast to zero bytes
auryn-macmillan Jul 17, 2023
e5c8532
use `new bytes(0)`
auryn-macmillan Jul 19, 2023
0a646b1
use "" for empty bytes
auryn-macmillan Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions contracts/core/Module.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ abstract contract Module is FactoryFriendly, Guardable {
0,
address(0),
payable(0),
bytes("0x"),
"",
msg.sender
);
success = IAvatar(target).execTransactionFromModule(
Expand All @@ -69,7 +69,7 @@ abstract contract Module is FactoryFriendly, Guardable {
data,
operation
);
IGuard(currentGuard).checkAfterExecution(bytes32("0x"), success);
IGuard(currentGuard).checkAfterExecution(bytes32(""), success);
} else {
success = IAvatar(target).execTransactionFromModule(
to,
Expand Down Expand Up @@ -107,7 +107,7 @@ abstract contract Module is FactoryFriendly, Guardable {
0,
address(0),
payable(0),
bytes("0x"),
"",
msg.sender
);
(success, returnData) = IAvatar(target)
Expand All @@ -117,7 +117,7 @@ abstract contract Module is FactoryFriendly, Guardable {
data,
operation
);
IGuard(currentGuard).checkAfterExecution(bytes32("0x"), success);
IGuard(currentGuard).checkAfterExecution(bytes32(""), success);
} else {
(success, returnData) = IAvatar(target)
.execTransactionFromModuleReturnData(
Expand Down
Loading