Update to ethers v6 #152
Merged
Update to ethers v6 #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value for node was set to 16, but the project was not installable with it. [email protected] needed at least node 16.13.0 and [email protected] needed at least 16.14.0, so decided to bump everything to at least 18.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
jfschwarz
requested changes
Jan 12, 2024
Unfortunately there is a bug in typechain and we get some name clashes in the generated code. There is a PR that fixes this, but until it gets merged I’ve added a patch. More info on the name clash: dethcrypto/TypeChain#887 Once this PR is merged the patch could be removed.
compojoom
force-pushed
the
update_to_ethers_v6
branch
from
ba58580
to
f51ba56
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not following the PR guide as this PR is neither a feature, nor a bug fix. So neither of the templates was fiting.
This PR updates ethers.js dependency to the currently latest ethers-v6 - 6.9.2
Implementation
All tests have been adjusted and pass.
Typescript definitions have also been updated.
Additional Context
We need this because we are upgrading the safe-wallet-app to use ethers-v6 (safe-global/safe-wallet-web#3087) and having zodiac rely on ethers-v5 screws with our types and requires us to do some gymnastics around types... Also we end up with BigNumber and bigints and we would just want to move ahead :)