Move moduleOnly only to more straigthforward shape

gnosisguild · Sep 28, 2023 · 5bb10dc · 5bb10dc
1 parent 5f60895
commit 5bb10dc
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/contracts/core/Modifier.sol b/contracts/core/Modifier.sol
@@ -74,15 +74,10 @@ abstract contract Modifier is Module, IAvatar, EIP712Signature {
     */
 
     modifier moduleOnly() {
-        bool wasSent = modules[msg.sender] != address(0);
-        bool wasSigned = !wasSent && modules[eip712SignedBy()] != address(0);
-        bool isAuthorized = wasSent || wasSigned;
-
-        if (!isAuthorized) {
-            revert NotAuthorized(msg.sender);
-        }
-
-        if (wasSigned) {
+        if (modules[msg.sender] == address(0)) {
+            if (modules[eip712SignedBy()] == address(0)) {
+                revert NotAuthorized(msg.sender);
+            }
             eip712BumpNonce();
         }