Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded FHE params #115

Closed
2 tasks done
ryardley opened this issue Sep 26, 2024 · 1 comment · Fixed by #117
Closed
2 tasks done

Remove hardcoded FHE params #115

ryardley opened this issue Sep 26, 2024 · 1 comment · Fixed by #117
Assignees
@ryardley
Labels
bug Something isn't working Ciphernode Related to the ciphernode package

Comments

@ryardley
Copy link
Contributor

ryardley commented Sep 26, 2024 •
edited
Loading

Currently the FHE params are hardcoded as events are parsed. This should be abi decoded from the EVM event.

  • Create a bfvpar that ABI encodes params to hex stdout
  • Create a params decoder function to decode the params from the EVM event
yarn committee:new --e3-params $(bfvpar --moduli 0x123,0x456 --plaintext-modulus 12345678 --degree 4321 --crpgen)
@ryardley ryardley added bug Something isn't working Ciphernode Related to the ciphernode package labels Sep 26, 2024
@ryardley ryardley self-assigned this Sep 27, 2024
@ryardley ryardley mentioned this issue Sep 27, 2024
Merged
10 tasks
@ryardley
Copy link
Contributor Author

ryardley commented Sep 30, 2024 •
edited
Loading

We have agreed to use the to_bytes() output from BfvParameters in rust as well as abi_encode this with the input validation contract address. See (https://github.com/gnosisguild/enclave/pull/117/files#diff-c0996943128d6619c9ab9289e465025a35ddcf37a505bb5d0ce91476ebe1220fR125). This has some implications for when committees are requested by browser or cli clients written in Typescript without a wasm embed. Our other option would include a wasm embed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryardley ryardley

Labels
bug Something isn't working Ciphernode Related to the ciphernode package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Decoding params from contract gnosisguild/enclave
1 participant
@ryardley