Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnovm/stdlibs: tests take too long to run even a single one #3421

Open
odeke-em opened this issue Dec 28, 2024 · 1 comment
Open

gnovm/stdlibs: tests take too long to run even a single one #3421

odeke-em opened this issue Dec 28, 2024 · 1 comment
Labels
🐞 bug Something isn't working

Comments

@odeke-em
Copy link
Contributor

Description

If I do

cd gnovm/stdlibs/bytes
gno test -v -run=TestCompareIdentical .
=== RUN   TestCompareIdenticalSlice
--- PASS: TestCompareIdenticalSlice (0.00s)
ok      . 	76.10s

76.10 seconds to run a single test is too long and that impedes the speed of development

For a comparison, the equivalent in the Go standard library takes less than 1 second

$ go test -run=CompareIdentical -v
=== RUN   TestCompareIdenticalSlice
--- PASS: TestCompareIdenticalSlice (0.00s)
PASS
ok  	bytes	0.048s

and to run even the entire suite of tests in the Go bytes packages takes less than 1 second

PASS
ok  	bytes	0.974s

Your environment

  • Go version:go version devel go1.24-6405e60ca6 Wed Nov 27 06:35:34 2024 +0000 linux/amd64
  • OS and CPU architecture: linux/amd64
  • Gno commit hash causing the issue (example: f24690e)

Suggestion

I highly recommend that performance of such be looked at as a serious incentive to make performance a huge win for not only tests and velocity of improvements but also for general performance.If the tests take 70X longer than the standard library, then even the VM must be suffering with bad performance and has been undiagnosed for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
Status: Triage
Development

No branches or pull requests

2 participants