Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question about cf. in input #64

Closed
abubelinha opened this issue Nov 23, 2021 · 6 comments
Closed

question about cf. in input #64

abubelinha opened this issue Nov 23, 2021 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@abubelinha
Copy link

abubelinha commented Nov 23, 2021

Some results of my Python calls to https://verifier.globalnames.org/api/v1/verifications/

  • Input 1: Phacopsis oxyspora var. defecta Triebel & Rambold
    Bestresult: [Index Fungorum (5) 413758]: Phacopsis oxyspora var. defecta Triebel & Rambold 1995

  • Input 2: Phacopsis oxyspora cf. var. defecta Triebel & Rambold
    Bestresult: [Catalogue of Life (1) 4FKN3]: Phacopsis oxyspora (Tul.) Triebel & Rambold
    Preferred: [Index Fungorum (5)134632]: Phacopsis oxyspora (Tul.) Triebel & Rambold 1988

I would expect that with or without "cf.", the input should match the infraspecific rank.
But when "cf." is present gnames matched the next higher taxonomic rank (not sure if this is on purpose or not)

I have only seen this with infraspecific ranks input. With species input, that is not happening:

  • Input 3: Phacopsis cf. oxyspora
    Bestresult: [Catalogue of Life (1) 4FKN3]: Phacopsis oxyspora (Tul.) Triebel & Rambold
    Preferred: [Index Fungorum (5)134632]: Phacopsis oxyspora (Tul.) Triebel & Rambold 1988

May this be a bug, or should I take care of removing "cf." myself from input, to get my expected results in output?
I linked years above to a different question. Thanks!

@dimus
Copy link
Member

dimus commented Nov 23, 2021

The reason behind it is the semantic meaning of 'cf.' in the name https://en.wikipedia.org/wiki/Cf.

GNparser considers names with cf. to be be surrogates, assuming someone could not identify species correctly, and compared them to something that they are 'not'. So in this case it would be a mistake to match such name with details after cf. annotation.

@dimus dimus closed this as completed Nov 23, 2021
@abubelinha
Copy link
Author

abubelinha commented Nov 25, 2021

Yes, I understand what you mean.
The part of the name after cf. is just a guess/suggestion (might be or might be not correct). So gnverifier takes the more conservative approach and decides not to take it into account:

So in this case it would be a mistake to match such name with details after cf. annotation.

No problems with that (if I do prefer to be risky, I could just remove " cf. " from the names in advance)

But the same gnverifier logic should be applied to both specific and infraspecific ranks. Shouldn't it?

You say Phacopsis cf. oxyspora should be matched to Phacopsis (and not Phacopsis oxyspora),
But that's not happening (see api link or 3rd example above).
Am I missing something?

@dimus
Copy link
Member

dimus commented Nov 25, 2021

You say Phacopsis cf. oxyspora should be matched to Phacopsis (and not Phacopsis oxyspora),

looks like a bug in gnparser, adding an issue there

@dimus
Copy link
Member

dimus commented Nov 25, 2021

gnames/gnparser#216

@dimus
Copy link
Member

dimus commented Nov 26, 2021

I was wrong actually @abubelinha, gnparser suppose to stop parsing if 'aff.' used, while for 'cf.' we decided to parse name anyway,
but issue a warning and bring quality to 4. So you are correct that Phacopsis oxyspora cf. var. defecta Triebel & Rambold should give the same canonical as Phacopsis oxyspora var. defecta Triebel & Rambold according to our rules. I just did not implement 'cf.' for infraspecies yet. So I will change gnames/gnparser#216 accordingly

@abubelinha
Copy link
Author

Thanks @dimus
I agree: aff. xxx means "this resembles but is different to xxx" (a negative meaning).
But cf. xxx means "this could be xxx" (a positive meaning, saying nothing against xxx).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants