Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid flatpak install on applications already present in nix-flapatk old state #110

Open
gmodena opened this issue Dec 3, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@gmodena
Copy link
Owner

gmodena commented Dec 3, 2024

Follow up from a conversation in #106.

nix-flaptak runs a flatpak install command during each activation. However, unless the user configures onActivation or auto, the operation is idempotent: flatpak detects that the app is already installed and skips reinstallation.

That said, this introduces unnecessary network operations (e.g., looking up the ref in its remote), which are both wasteful and can break network-less activations.

We should avoid running flatpak install <appId> is appId was already present in the previous nix-flatpak activation state.

@gmodena gmodena added the enhancement New feature or request label Dec 3, 2024
@gmodena gmodena added this to the 1.0.0 milestone Dec 3, 2024
@gmodena
Copy link
Owner Author

gmodena commented Dec 3, 2024

This should help mitigate #45 and general issues with network flakyness.

@gmodena gmodena self-assigned this Dec 7, 2024
@gmodena gmodena modified the milestones: 1.0.0, 0.5.0 Dec 7, 2024
@gmodena gmodena changed the title Avoid flatpak install on applications alrady present in nix-flapatk old state Avoid flatpak install on applications already present in nix-flapatk old state Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant