Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take parameters from SC and give preference. #22

Open
humblec opened this issue Aug 30, 2018 · 5 comments
Open

Take parameters from SC and give preference. #22

humblec opened this issue Aug 30, 2018 · 5 comments
Assignees
@jarrpa @humblec
Labels
in progress MVP 1.0 Taks need to be completed for MVP 1.0

Comments

@humblec
Copy link
Contributor

humblec commented Aug 30, 2018

At present the parameters for provisioner has been taken from ENV which has to be changed and enabled for SC parameter list. The TODO in the csi driver commit
https://github.com/gluster/gluster-csi-driver/blob/master/pkg/glusterfs/controllerserver.go#L59 has to be enabled and given priority over ENV
@humblec
Copy link
Contributor Author

humblec commented Aug 30, 2018

@Madhu-1 I believe I explained this requirement clearly, if not let me know. I can share more details. If it was clear, please send a PR.

@humblec
Copy link
Contributor Author

humblec commented Aug 30, 2018

/assign @Madhu-1

@humblec humblec added the MVP 1.0 Taks need to be completed for MVP 1.0 label Aug 30, 2018
@Madhu-1 Madhu-1 mentioned this issue Aug 30, 2018
Closed
@humblec humblec self-assigned this Sep 12, 2018
@JohnStrunk
Copy link
Member

I'm still unclear about what benefit this provides to the admin. The CSI driver version (Gluster client) needs to stay in sync with the Gluster container version (Gluster server).

The most straightforward way to accomplish that (automatically, in a scalable way) is by having 1 csi driver instance per Gluster cluster. Going that route, there is no need to repeat the cluster connection info in each StorageClass object. It can be provided to the driver once at startup.

@humblec could you better describe the user value of putting this info in the SC?

@jarrpa jarrpa mentioned this issue Nov 12, 2018
Open
@ghost ghost assigned jarrpa Nov 12, 2018
@atinmu
Copy link

atinmu commented Jan 17, 2019

@JohnStrunk @humblec What's the definition of MVP 1.0 label? Is it equivalent to GCS 1.0? If so can you please retag it with GCS/1.0 based on if the work can get completed in 2 week's time?

@JohnStrunk
Copy link
Member

This is not a priority for GCS 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jarrpa jarrpa

@humblec humblec

Labels
in progress MVP 1.0 Taks need to be completed for MVP 1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jarrpa @humblec @JohnStrunk @atinmu