Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early access release includes non-artifact files #768

Closed
jperedadnr opened this issue Oct 22, 2024 · 3 comments · Fixed by #769
Closed

Early access release includes non-artifact files #768

jperedadnr opened this issue Oct 22, 2024 · 3 comments · Fixed by #769
Assignees
Labels
bug Something isn't working

Comments

@jperedadnr
Copy link
Collaborator

jperedadnr commented Oct 22, 2024

After #766, the early access workflow publishes, as GitHub early access release, txt and arc files along with the binaries of the artifacts.
Those shouldn't be there.

Expected Behavior

Current Behavior

Steps to Reproduce

Your Environment

Screenshots

@jperedadnr jperedadnr added the bug Something isn't working label Oct 22, 2024
@jperedadnr jperedadnr self-assigned this Oct 22, 2024
@jperedadnr jperedadnr changed the title Early access release include non-artifact files Early access release includes non-artifact files Oct 22, 2024
@aalmiray
Copy link
Collaborator

Those files are used to allow consumers perform verifications on published artifacts. Why would you want to skip them from a release?

@jperedadnr
Copy link
Collaborator Author

Note this is only for the GitHub release block (not for Maven Central). Having the signatures/checksums with the binaries makes it confusing for users that simply want to download from the GitHub release.

So far, we didn't publish them, as they only show up now after we started signing them for the Scene Builder Kit release to Maven Central.

@aalmiray
Copy link
Collaborator

Is it really confusing for users? I mean, a txt file that does not match the name of the intended artifact (the kit) plus another filename with .asc extension. Alas, it's your prerogative as project maintainer. The good thing is if those files were to be requested by users then enabling is just a quick DSL update away ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants