Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Tests which ran in the non-modular setup are now failing with the new modular setup #733

Open
Oliver-Loeffler opened this issue Sep 29, 2024 · 0 comments · May be fixed by #576 or #579
Open
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Oliver-Loeffler
Copy link
Collaborator

Certain tests, e.g. as provided in PR #576 are now failing with the current setup using Maven-Surefire 3.0.0-M5.

Expected Behavior

  • tests shall pass (as those test passed w/o module-info.java)

Current Behavior

  • tests in kit break with an error message about wrong module configuration
[ERROR] Errors:
[ERROR]   FXOMImportsRemoverTest.that_fxml_is_not_modified_when_nothing_is_to_be_removed » InaccessibleObject
[ERROR]   FXOMImportsRemoverTest.that_the_given_imports_are_removed » InaccessibleObject
[ERROR]   FXOMRefresherTest » InaccessibleObject Unable to make public static void com.o...
[ERROR]   FXOMSaverTest » InaccessibleObject Unable to make public static void com.oracl...

Steps to Reproduce

  • clone Scene Builder from issue-120 and checkout commit 55f95ab.
  • cd into kit and run mvnw verify

Your Environment

  • Windows 22H2
  • Java 23
  • OpenJFX 23
  • Maven 3.9.9

Screenshots

grafik

grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment