Update test_trace to specreduce 1.4 interface #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhomeier
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 96.68% 96.69% +0.01%
==========================================
Files 18 18
Lines 1448 1453 +5
==========================================
+ Hits 1400 1405 +5
Misses 48 48 ☔ View full report in Codecov by Sentry. |
dhomeier
force-pushed
the
trace-image
branch
2 times, most recently
from
e3cfc60 to
49b2482
Compare
|
I am merging to get the CI working again; can consider adding noise later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Function name has been changed in astropy/specreduce#165. This has also introduced a new, default-True option
add_noise, which requiresphotutils. I suppose it is not of interest for the functionality tested here, or should I addphotutilsto test-deps and use the default?