You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As it stands today gltf::import_buffers requires it's blob parameter to be a Vec<u8> since an underlying call to gltf::buffer::Data::from_source_and_blob may mutate this input blob to align it's size to a multiple of four.
I would like this parameter to be a u8 slice so we may feed it the resulting blob from a gltf::Gltf::from_slice import without having to turn that Cow into a Vec.
I suggest we make having an unaligned slice an error and return that from gltf::buffer::Data::from_source_and_blob if it's given one.
I volunteer to try to implement this under the V2 branch.
The text was updated successfully, but these errors were encountered:
As it stands today
gltf::import_buffers
requires it'sblob
parameter to be aVec<u8>
since an underlying call togltf::buffer::Data::from_source_and_blob
may mutate this input blob to align it's size to a multiple of four.I would like this parameter to be a
u8
slice so we may feed it the resulting blob from agltf::Gltf::from_slice
import without having to turn thatCow
into aVec
.I suggest we make having an unaligned slice an error and return that from
gltf::buffer::Data::from_source_and_blob
if it's given one.I volunteer to try to implement this under the V2 branch.
The text was updated successfully, but these errors were encountered: