Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional validation tests #210

Closed
joaander opened this issue Dec 6, 2016 · 8 comments · Fixed by #1428
Closed

Additional validation tests #210

joaander opened this issue Dec 6, 2016 · 8 comments · Fixed by #1428
Assignees
Labels
essential Work that must be completed. eventually Things that might get done, eventually refactor Refactoring existing code

Comments

@joaander
Copy link
Member

joaander commented Dec 6, 2016

Original report by me.


Pull request #278 along with a Jenkins reconfiguration paves the way for long running validation tests as part of hoomd's unit test suite. We need to expand the validation tests with additional tests for MD.

As part of this effort, I would like to simplify the cmake files. Currently we have a LOT of copied and pasted add_test code around. We could simplify that down to a simple macro which all the various cmake scripts call when they want to add a test.

The doumentation needs to be updated to describe the validation testing procedures, including a list of compile options and what hardware / compiler versions we officially validate.

@joaander
Copy link
Member Author

joaander commented Dec 7, 2016

Also configure a release testing branch where jenkins will run tests on all GPUs to ensure functionality.

@joaander
Copy link
Member Author

deferring

@joaander
Copy link
Member Author

BUILD_VALIDATION should be renamed so that it covers all long tests, not just validation ones.

@joaander
Copy link
Member Author

Bumping to the next feature release.

@joaander joaander added major eventually Things that might get done, eventually refactor Refactoring existing code and removed major labels Feb 12, 2019
@joaander joaander added this to the v3.0 milestone Jul 24, 2019
@joaander joaander removed this from the v3.0.beta.1 milestone Oct 7, 2020
@joaander
Copy link
Member Author

Once #888 and #996 are merged, we should port over the rigid body validation tests from hoomd v2.

@joaander
Copy link
Member Author

While we can use the validation framework for some simulations, others require run times so long that we cannot run them in the CI framework - e.g. the hard disk equation of state in #985. We need to consider options for organizing these tests to run manually on HPC resources. One option would be a separate repository and use signac-flow to manage the jobs.

@joaander
Copy link
Member Author

As the plan is now to write a separate framework, this is not critical to complete before the 3.0.0 release.

@joaander joaander added this to the future milestone Jul 21, 2021
@joaander joaander added essential Work that must be completed. labels Feb 4, 2022
@joaander joaander removed this from the future milestone Mar 8, 2022
@joaander joaander mentioned this issue Apr 12, 2022
3 tasks
@joaander
Copy link
Member Author

joaander commented Apr 13, 2022

Some of the tests to include in validation:

  • Hard disk equation of state
  • Lennard-Jones equation of state (including via off-center rigid spheres to test rigid body pressure)
  • Spherical depletants in HPMC.
  • Energy conservation in MD.
  • Energy drift in MD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
essential Work that must be completed. eventually Things that might get done, eventually refactor Refactoring existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants