Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YES/NO enumerated-string parsing returns string rather than bool #377

Open
davemevans opened this issue Jul 31, 2024 · 1 comment
Open

Comments

@davemevans
Copy link
Contributor

There are a bunch of attributes of type enumerated-string with values "YES" (and sometimes "NO") (eg EXT-X-DATERANGE END-ON-NEXT).

The parser will currently return these as raw strings. Turns out this is a bit awkward to work with, and these values would be more straightforward to use if returned as bools (ie testing == "YES" rather than is True).

I can put together a patch to parse these attributes as bools, but it would be a breaking change.

What do people think?

@mauricioabreu
Copy link
Member

@davemevans sounds good. Submit your PR, then we can discuss there. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants