Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some new relations #57

Open
fcbond opened this issue Oct 30, 2020 · 12 comments
Open

Add some new relations #57

fcbond opened this issue Oct 30, 2020 · 12 comments
Assignees
Labels
enhancement New feature or request

Comments

@fcbond
Copy link
Member

fcbond commented Oct 30, 2020

We want to add some new relations, these are all already in use by some wordnets.

  • Simple Aspect
  • Secondary Aspect
  • Feminine form
  • Masculine Form
  • Young Form
  • Diminutive
  • Augmentative
  • Gradable Antonym
  • Simple Antonym
  • Converse Antonym
  • Inter-register Synonym

Most of these are used by the Polish Wordnet Project, some by Czech and Bulgarian.

@fcbond fcbond added the enhancement New feature or request label Oct 30, 2020
@fcbond
Copy link
Member Author

fcbond commented Nov 3, 2020

@ewa-rudnicka and @fcbond are still hashing out if some of the relations should be symmetric or appear in pairs. Probably only the synonym and antonym relations should be symmetric.

@fcbond
Copy link
Member Author

fcbond commented Dec 22, 2020

Basic documentation added by b4dbc8c

@jmccrae
Copy link
Member

jmccrae commented Dec 29, 2020

A couple of comments on the implementation of these new relationships:

  1. Could we lose the _of from property names like augmentative_of? This would fit the style better
  2. simple_aspect_pi and secondary_aspect_pi are marked as not directly applicable. So what is the point of them??
  3. ir_synonym is allowed between senses, but its parent relationship is not. This is a contradiction. I think that ir_synonym should not be allowed between senses
  4. Similarly, simple_aspect_ip and secondary_aspect_ip are allowed between synsets, but not between its parent derivation. Again this is contradictory and we should probably not allow this.

@goodmami
Copy link
Member

A couple of comments on the implementation of these new relationships:

  1. Could we lose the _of from property names like augmentative_of? This would fit the style better

I also prefer without _of, but I'm not sure we have a consistent style. Here are some existing relations with of:

  • state_ofbe_in_state
  • subeventis_subevent_of
  • manner_ofin_manner

Similarly, these by ones are inconsistent:

  • restrictsrestricted_by
  • entailsis_entailed_by

Maybe we could use some relation naming guidelines.

  1. simple_aspect_pi and secondary_aspect_pi are marked as not directly applicable. So what is the point of them??

"(not directly applicable)" is what is shown by the HTML templates when a relation is not marked as a synset-synset, sense-sense, or sense-synset relation (e.g., for constitutive). My guess is that someone forgot to mark these relations as such. Otherwise I'd agree that there's no point. I think for "constitutive", which is not defined in the DTD, it is only there to group related relations as a supertype. Maybe it should go?

  1. ir_synonym is allowed between senses, but its parent relationship is not. This is a contradiction. I think that ir_synonym should not be allowed between senses

I see the logical argument, and also I think it's easier to start with a tight schema then loosen it later than vice versa. However, in the Japanese Wordnet we have words sharing a synset where some are interregister synonyms (e.g., 召し上がる, 召しあがる, 召上る (yes, three of them), 召される, 召す, 上がる, 食事, 食む, 食らう, 食う, 食べる, 食する, and 頂く all share a synset). These cannot be modeled with a synset-only relation. But maybe adapting the schema to the data we have is putting the cart before the horse and we should instead change the data (e.g., splitting those into different synsets)?

  1. Similarly, simple_aspect_ip and secondary_aspect_ip are allowed between synsets, but not between its parent derivation. Again this is contradictory and we should probably not allow this.

Ditto my first sentence from (3) above. I don't have any opinion or counterexamples otherwise.

I have another related concern:

  1. I find the _form relations (feminine_form, masculine_form, etc.) slightly odd. Why are we talking about "form" at the synset level? That seems like a word (or sense) thing. Why not just feminine, masculine, etc.?

@jmccrae
Copy link
Member

jmccrae commented Jan 12, 2021

Yes, for 1 and 5 I also prefer shorter names.

On 3, I think that this is something that should be fixed in Japanese WordNet, Typically, register changes (e.g., 'bloke' vs 'man') are different synsets in wordnets.

@fcbond
Copy link
Member Author

fcbond commented Jan 13, 2021 via email

@fcbond
Copy link
Member Author

fcbond commented Jan 13, 2021 via email

@fcbond
Copy link
Member Author

fcbond commented Jan 13, 2021 via email

@goodmami
Copy link
Member

Just confirming that ir_synonym is changed to synset-synset and not sense-sense as written above?

Also, I see that you've changed masculine to male and feminine to female. My qualm was with using the _form suffix, not with the masculine/feminine part. There are times that the grammatical gender does not match the natural gender (for example, from Wikipedia, cailín "girl" (Irish) is masculine), so male/female might be problematic. Which are we annotating?

@fcbond
Copy link
Member Author

fcbond commented Jan 14, 2021 via email

@fcbond
Copy link
Member Author

fcbond commented Jan 28, 2021 via email

@jmccrae
Copy link
Member

jmccrae commented Jan 29, 2021

Will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants