You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why does it check for this type and not cancel the context for other types of errors? I am using github.com/hashicorp/yamux to provide the underlying net.Conn and it returns io.EOF when the stream is closed - which isn't a net.Error, so the context doesn't get cancelled and the connection just hangs around.
Am I perhaps misunderstanding some details? Or is this a bug?
The text was updated successfully, but these errors were encountered:
Love the library - it's brilliant. One question:
In
(*serverConn).Read
and(*serverConn).Write
, there is the following line that only cancels the context if the error is anet.Error
:ssh/conn.go
Line 20 in 59d6e45
Why does it check for this type and not cancel the context for other types of errors? I am using
github.com/hashicorp/yamux
to provide the underlyingnet.Conn
and it returnsio.EOF
when the stream is closed - which isn't anet.Error
, so the context doesn't get cancelled and the connection just hangs around.Am I perhaps misunderstanding some details? Or is this a bug?
The text was updated successfully, but these errors were encountered: