Splitting up radial (pseudo) caustics

[leier]

in find_crit.cpp producing caustics with half-moon shape (see figure below)
from the Example2.cpp for a
halo initialized with the following params
LensHaloRealNSIE newhalo(1.0e14,zl,200,0,0.7,10,0);

output according to:

std::cout << " caustic " << critcurve[i].critical_center[0] <<" " << critcurve[i].critical_center[1] << " " << critcurve[i].caustic_area << " " << rmax << " " << rmin << " " << rave << std::endl;

is

0 type 2
caustic -3.32816e-08 -1.28919e-07 1.41607e-12 1.22249e-06 5.41685e-07 8.7387e-07
critical 6.75349e-11 5.67382e-06 3.83423e-06 4.66727e-06
1 type 2
caustic -1.10157e-05 -1.10157e-05 0 0 0 0
critical 0 0 0 0
2 type 3
caustic -1.97095e-09 -3.64991e-10 6.58967e-11 4.86375e-06 4.3151e-06 4.6035e-06
critical 0 0 0 0
3 type 3
caustic -1.32078e-08 -4.60035e-08 5.07488e-13 1.92917e-06 1.17826e-07 9.84402e-07
critical 0 0 0 0

[leier]

Btw. substituting the convex_hull function (also used for the radial caustic in my last comment) by concave_hull leads to the following output (the 2nd radial contour, former halfmoon, is still there and distinctly separate from the outer radial caustic, though the part connecting its endings is gone, well that just means that the algorithm is doing what it should):

[leier]

The bug (offset of caustic and critical lines) was introduced in revision f0d0cb4