Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing errors can lead to increased CPU usage #25

Open
rickyes opened this issue Nov 6, 2018 · 2 comments
Open

Signing errors can lead to increased CPU usage #25

rickyes opened this issue Nov 6, 2018 · 2 comments

Comments

@rickyes
Copy link

rickyes commented Nov 6, 2018

I found that parsing the wrong zip resulted in increased CPU usage, and I found a problem after debug:

Parse.prototype._flush = function (callback) {
  if (!this._streamEnd || !this._streamFinish) {
    return setImmediate(this._flush.bind(this, callback));
  }

  this.emit('close');
  return callback();
};

Here _streamEnd and _streamFinish variables has been meet the conditions, so constantly registered setImmediate to the event loop

@bakso
Copy link

bakso commented May 31, 2019

+1

@liangzhuang327
Copy link

use unzip.Extract, Cpu soars from 4% to 50% and does not recover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants