Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract fails when a filesize of 0 bytes is encountered. #2

Open
smithandweb opened this issue Jan 23, 2015 · 4 comments
Open

Extract fails when a filesize of 0 bytes is encountered. #2

smithandweb opened this issue Jan 23, 2015 · 4 comments

Comments

@smithandweb
Copy link

Same for Parse. Tested by writing white space to empty files and Parse and Extract worked as expected. Function stops at first encounter.
@austinhallock
Copy link

The problem seems to be in the Pullstream lib: https://github.com/EvanOxfeld/node-pullstream/blob/master/pullstream.js#L64

changing that to if (len === null) { fixes it on our end

@antonydb
Copy link

👍 Thanks @austinhallock . Solved my issue :)

@jakubknejzlik
Copy link

I've already created pull request for pullstream ... hope they will merge it soon.

@suisho suisho mentioned this issue May 21, 2015
Closed
@vikbez vikbez mentioned this issue May 21, 2015
Open
@feiyuw
Copy link

feiyuw commented Nov 25, 2015

+1 thanks @austinhallock . You solved my issue.

@feiyuw feiyuw mentioned this issue Nov 25, 2015
Closed
tlancina added a commit to ionic-team/ionic-app-lib that referenced this issue Apr 6, 2016
@tlancina
fix(start): use adm-zip instead of unzip2
41e37a0 
Addresses ionic-team/ionic-cli#908. There is a
bug in the unzip2 library that causes unzipping to break when it
encounters an empty file:
glebdmitriew/node-unzip-2#2.
tlancina added a commit to ionic-team/ionic-app-lib that referenced this issue Apr 6, 2016
@tlancina
fix(start): use adm-zip instead of unzip2
5d49794 
Addresses ionic-team/ionic-cli#908. There is a
bug in the unzip2 library that causes unzipping to break when it
encounters an empty file:
glebdmitriew/node-unzip-2#2.
@tlancina tlancina mentioned this issue Apr 6, 2016
Merged
jthoms1 pushed a commit to ionic-team/ionic-app-lib that referenced this issue Apr 11, 2016
@tlancina @jthoms1
fix(start): use adm-zip instead of unzip2 (#87)
b7c7977 
Addresses ionic-team/ionic-cli#908. There is a
bug in the unzip2 library that causes unzipping to break when it
encounters an empty file:
glebdmitriew/node-unzip-2#2.
@raphaelrpl raphaelrpl mentioned this issue Oct 10, 2018
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jakubknejzlik @austinhallock @feiyuw @antonydb @smithandweb