#36 | BUG/3 Suggestions and original sentences are loaded simultaneously | Artem #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://gaelic-project-pr-37.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-ckj7aub6fquc73febejg. |
filkovskyy
requested review from
ali-nasir-ali,
Melesegithub and
AppolinFotso
Comment on lines
+39
to
+43
| useEffect(() => { | ||
| if (randomText !== "Loading...") { | ||
| getSuggestionsFromApi(randomText); | ||
| } | ||
| }, [randomText]); |
There was a problem hiding this comment.
I like this implementation and it will be great to incorporate this with the LoadingSuggestion which is a spinning image from BUG-1 fix.
|
Hi, do note there's a conflict between this and the loading page fix code. Also note the loading page fix did already solve this partially, so make sure this piece of code is actually still required or not |
|
Going to close this as I believe it's not needed anymore with the spinner solution we have right now. Feel free to re-open if you still believe this is useful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suggestions and original sentences are loaded simultaneously.
The changes ensure that the original sentence and suggestions are initially set to "Loading..." and only change when the suggestions are fully loaded from the API.
Changes:
Defined a new function getSuggestionsFromApi at the beginning of the Home function. This function is responsible for fetching suggestions from the API, updating the suggestions state, setting the original sentence, and updating the loading state.
Modified the loadRandomSentenceFromFile function inside the first useEffect hook to call getSuggestionsFromApi after fetching the random sentence. This ensures that the original sentence is set only after the suggestions have been loaded.
Modified the second useEffect hook to call getSuggestionsFromApi only when randomText is not "Loading...". This ensures that the suggestions are fetched and the loading state is updated only when the original sentence is not in the loading state.
Related to
Bug fix #36
Checklist: