Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OKLCH support in css() #325

Closed
oskarkrawczyk opened this issue Feb 3, 2024 · 8 comments
Closed

OKLCH support in css() #325

oskarkrawczyk opened this issue Feb 3, 2024 · 8 comments
Assignees
@gka
Labels
feature

Comments

@oskarkrawczyk
Copy link

Right now the css() method only supports two modes of generating a CSS string, rgb and hsl – would it be possible to provide additional types, like oklch?
@regorxxx
Copy link

regorxxx commented Feb 4, 2024

See this #321

@oskarkrawczyk
Copy link
Author

See this #321

Thanks, I had a look but it seems the CSS method still only supports three modes of output: hex, rgb, hsl.

@regorxxx
Copy link

regorxxx commented Feb 4, 2024

I'm just pointing you to open issues to maintained forks, not here.

regorxxx added a commit to regorxxx/chroma.js that referenced this issue Feb 5, 2024
@regorxxx
* added LAB, LCH, OKLCH and OKLAB support in "chroma.css()" [Issue 325](
d078938 
gka#325)

Signed-off-by: regorxxx <[email protected]>
@regorxxx
Copy link

regorxxx commented Feb 5, 2024

Have updated the methods to support it.

@oskarkrawczyk
Copy link
Author

@regorxxx wow, that's really great! I'm switching to your fork

@gka gka self-assigned this Aug 8, 2024
@gka gka added the feature label Aug 8, 2024
@gka
Copy link
Owner

gka commented Aug 8, 2024

fwiw, this will also land in the original chroma.js soon 👋

@gka
Copy link
Owner

gka commented Aug 14, 2024

will be resolved in #347

@gka
Copy link
Owner

gka commented Aug 17, 2024

this feature is shipped with version 3.0!

@gka gka closed this as completed Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gka gka

Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oskarkrawczyk @gka @regorxxx