Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Period end should have same date format as Period start #1021

Open
kristoferlund opened this issue May 17, 2023 · 3 comments
Open

Period end should have same date format as Period start #1021

kristoferlund opened this issue May 17, 2023 · 3 comments
Labels
dashboard good first issue Good for newcomers

Comments

@kristoferlund
Copy link
Member

Later we will try to use localized dates all over but for now let's stick with the pattern "YYYY-MM-DD".

Image
@ujwalkumar1995
Copy link
Contributor

Hey @kristoferlund
I would like to work on this. Could you please assign?

@kristoferlund
Copy link
Member Author

Welcome @ujwalkumar1995! Let me know if you have any issues setting up Praise locally.

Prerequisite: Docker

nvm use
yarn
yarn mongodb:start
yarn setup
yarn workspace api start:debug
yarn workspace frontend start

@ujwalkumar1995 ujwalkumar1995 mentioned this issue May 18, 2023
Merged
@kristoferlund
Copy link
Member Author

Partially fixed in #1025

Issue remains that display format of input field is wrong. Possible solutions:

  • Use oter date input component
  • Do some sort of frontend trick where what is displayed is not actually the date input field

@ujwalkumar1995 unassigning you from this unless you want to keep at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dashboard good first issue Good for newcomers
Projects
Praise Development
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kristoferlund @ujwalkumar1995