Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Pricing for Product Options #269

Open
clho40 opened this issue Jan 30, 2025 · 1 comment
Open

Inconsistent Pricing for Product Options #269

clho40 opened this issue Jan 30, 2025 · 1 comment

Comments

@clho40
Copy link

clho40 commented Jan 30, 2025

Hello there,

I've come across a bug with the product option pricing, and it's quite confusing. Let me walk you through it.

You can reproduce this issue on [this demo product page](https://demo.vvveb.com/product/product-19) or any freshly installed Vvveb with demo data.

Step 1: Checking the Admin Panel

From the admin panel, go to Products > Product 19 > Option. Under the Size option, you’ll see that Large has its price set to 3.0000.

Now, here’s the first confusion (Marked 1 in the screenshot 1):

  • Does 3.00 mean the Large size will cost $3.00 in total?
  • Or does it mean $3.00 more than the base price?
  • Or is it 3.00% added on top of the base price?

Furthermore, there's another issue: if you try to select the minus option, it does not get saved. (Marked 2 in the screenshot 1)

Image

Step 2: Checking the Product Page

Now, let’s go to [the product page](https://demo.vvveb.com/product/product-19).

If we assume that 3.00 means $3.00 more, then selecting Large should increase the price by $3.00. But instead, it shows +$4.84. Where is this number coming from? (Marked 1 in the screenshot 2)

Even stranger, when you select Large, the product price does not update dynamically on the page. (Marked 2 in the screenshot 2)

Image

Step 3: Checking the Cart Page

Now, let’s add the product to the cart.

In the cart, the price updates—but this time, it correctly shows Large +$3.00. So, why does the product page show +$4.84, but the cart shows +$3.00? (Marked 1 in the screenshot 3)

From the screenshot the final product price is $260.83, and it is wrong! (Marked 2 in the screenshot 3)
The original price is 256.99.

  • 256.99 + 3.00 = 259.99
  • 256.99 + 4.84 = 261.83
    either option does not add up to $260.83!

Last but not least, the final price is still 256.99 without the additional cost (Marked 3 in the screenshot 3)

Image

Expected Behavior:

  • The price logic should be clear and consistent across the admin panel, product page, and cart.
  • Selecting an option should dynamically update the product price.
  • The minus selection should be saved correctly.

Would appreciate any insights or fixes for this issue. Thanks!

@givanz
Copy link
Owner

givanz commented Jan 30, 2025

Hi

Thanks for the detailed bug report.

Option price is fixed rate (not percent) and is added to base price.

I changed operator button color to make it more obvious that it's a button and fixed - (minus) button not being saved.

On product page the option price is shown with taxes added, this is why the value is 4.84 instead of 3, dynamic price change when changing options is not implemented yet.

On cart page product option price didn't include taxes and cart taxes didn't include product option value.

The fixes are available in the latest.zip update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants