I fixed the submitting of logos in site.html, but not sure how to contribute it

[christianWiegand]

Dear all,

I have two instances of vvveb cms on my webhosting. While building my website, suddenly, a wild bug appeared, that caused the logo upload in the website settings (settings → sites → sites → edit → general → logo) not to work anymore.
For example: the changed favicon is not saved. It's like this: I click on “Set image”, then the file selection window opens, I select a file and then click on “Add selected” and then the correct image is also displayed in the preview view. But when I refresh, the old image is there again. So apparently it has not persisted it.

Then I found, that the site.html is responsible for it. Then I debugged it and added the following code, wich fixed the issue:

  <script>
    // Auto-submit form when media is selected
    document.addEventListener('DOMContentLoaded', function() {
      window.addEventListener('click', function(e) {
        if (e.target.closest('.save-btn') && document.getElementById('MediaModal')) {
          setTimeout(() => {
            document.getElementById('settings-form').submit();
          }, 100);
        }
      });
    });
  </script>

The logos are now persited.
But when I tried to contribute it to the Vvveb CMS Repo, I found, that the file public\admin\default\settings\site.html doesn't exist.
So my question is, how can I contribute this fix?

Best regards,

Christian Wiegand

[givanz]

Hi

Site settings including fav icon are saved only after clicking "Save site" button, from your description and code I think you want to save it without clicking the button?

The admin theme is in a different repo https://github.com/givanz/vvveb-admin-template and included as a git submodule in the main repository, you need to pass --recurse-submodules parameter to git clone/pull to fetch submodules also.