Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request : On Click, Mark as Done #500

Closed
barraIhsan opened this issue May 1, 2021 · 6 comments · Fixed by #538
Closed

Feature Request : On Click, Mark as Done #500

barraIhsan opened this issue May 1, 2021 · 6 comments · Fixed by #538
Labels
enhancement New feature or enhancement to existing functionality

Comments

@barraIhsan
Copy link

So, when we click the notification, its mark as done
image
Why? Because I don't like my inbox still filling up with notification that I already Read

@manosim manosim added the github-api-limitation Limitation in data available from GitHub APIs label Jul 31, 2021
@manosim
Copy link
Member

manosim commented Jul 31, 2021

That's a good point - unfortunately the GitHub REST API doesn't provide an endpoint to mark notifications as read so there's not much we can do until they allow us to do so.

@adufr
Copy link
Contributor

adufr commented Jan 17, 2024

Hi! I'm a new Gitify user and I really enjoy this app, but it really annoys me too that I can't mark notifications as "done".

And after doing some digging: it looks like GitHub does now include an endpoint for that!
https://docs.github.com/en/rest/activity/notifications?apiVersion=2022-11-28#mark-a-thread-as-done

Maybe we can reopen this issue? I'd be happy to try and contribute!

@bmulholland bmulholland reopened this Jan 17, 2024
@bmulholland
Copy link
Collaborator

@adufr Sure :)

@fredrikaverpil
Copy link

Not having the regular GitHub notifications in sync with gitify was the main reason I couldn't use it. This is awesome! 🤩

@adufr
Copy link
Contributor

adufr commented Jan 17, 2024

I already have a working POC, I'll open a PR tomorrow! 😁

@adufr
Copy link
Contributor

adufr commented Feb 9, 2024

This issue can be closed as it's now completed thanks to both #706 and #746 🎉

@setchy setchy closed this as completed Feb 9, 2024
@setchy setchy added enhancement New feature or enhancement to existing functionality and removed feature-request labels Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants