test: login with github (#1551)

Signed-off-by: Adam Setch <[email protected]>
gitify-app · Sep 25, 2024 · ae72183 · ae72183
1 parent 888bac5
commit ae72183
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 10 deletions.
diff --git a/src/routes/Accounts.test.tsx b/src/routes/Accounts.test.tsx
@@ -239,12 +239,15 @@ describe('routes/Accounts.tsx', () => {
 
   describe('Add new accounts', () => {
     it('should show login with github app', async () => {
+      const mockLoginWithGitHubApp = jest.fn();
+
       await act(async () => {
         render(
           <AppContext.Provider
             value={{
               auth: { accounts: [mockOAuthAccount] },
               settings: mockSettings,
+              loginWithGitHubApp: mockLoginWithGitHubApp,
             }}
           >
             <MemoryRouter>
@@ -254,9 +257,9 @@ describe('routes/Accounts.tsx', () => {
         );
       });
 
-      expect(screen.getByTitle('Login with GitHub App').hidden).toBe(false);
+      fireEvent.click(screen.getByTitle('Login with GitHub'));
 
-      fireEvent.click(screen.getByTitle('Login with GitHub App'));
+      expect(mockLoginWithGitHubApp).toHaveBeenCalled();
     });
 
     it('should show login with personal access token', async () => {
@@ -275,11 +278,8 @@ describe('routes/Accounts.tsx', () => {
         );
       });
 
-      expect(screen.getByTitle('Login with Personal Access Token').hidden).toBe(
-        false,
-      );
-
       fireEvent.click(screen.getByTitle('Login with Personal Access Token'));
+
       expect(mockNavigate).toHaveBeenNthCalledWith(
         1,
         '/login-personal-access-token',
@@ -305,9 +305,8 @@ describe('routes/Accounts.tsx', () => {
         );
       });
 
-      expect(screen.getByTitle('Login with OAuth App').hidden).toBe(false);
-
       fireEvent.click(screen.getByTitle('Login with OAuth App'));
+
       expect(mockNavigate).toHaveBeenNthCalledWith(1, '/login-oauth-app', {
         replace: true,
       });

diff --git a/src/routes/Accounts.tsx b/src/routes/Accounts.tsx
@@ -186,7 +186,7 @@ export const AccountsRoute: FC = () => {
           <button
             type="button"
             className={BUTTON_CLASS_NAME}
-            title="Login with GitHub App"
+            title="Login with GitHub"
             onClick={loginWithGitHub}
           >
             <MarkGithubIcon

diff --git a/src/routes/Login.test.tsx b/src/routes/Login.test.tsx
@@ -48,6 +48,26 @@ describe('routes/Login.tsx', () => {
     expect(mockNavigate).toHaveBeenNthCalledWith(1, '/', { replace: true });
   });
 
+  it('should login with github', () => {
+    const mockLoginWithGitHubApp = jest.fn();
+    render(
+      <AppContext.Provider
+        value={{
+          loginWithGitHubApp: mockLoginWithGitHubApp,
+        }}
+      >
+        <MemoryRouter>
+          <LoginRoute />
+        </MemoryRouter>
+        ,
+      </AppContext.Provider>,
+    );
+
+    fireEvent.click(screen.getByLabelText('Login with GitHub'));
+
+    expect(mockLoginWithGitHubApp).toHaveBeenCalled();
+  });
+
   it('should navigate to login with personal access token', () => {
     render(
       <MemoryRouter>

diff --git a/src/routes/__snapshots__/Accounts.test.tsx.snap b/src/routes/__snapshots__/Accounts.test.tsx.snap