-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Training scripts on GHEC #406
Comments
I have a local branch where I've been working on it, but I haven't uploaded any of it here yet. What kind of access are you setting up in your token? I've found that for ours, we need someone who has org admin level access because we need to be able to invite users into our training org in GHEC. I haven't had any difficulties accessing the API for our set up for GHEC. |
Realized I should look at my .trainingmanualrc. I have this set for URLs:
I'd have to look at what changes I made specifically for GHEC since it's been a few months. I haven't contributed back yet because what I have is a bit hacky, and I want to clean things up first. I know when we worked on supporting both GHES and .com, there are conditionals that treat the two differently in some ways. As written, the scripts would treat GHEC as .com based on the base URLs which isn't always what we want. There are some subtleties, and GHEC does behave more like GHES. |
Thank you for the input @amyschoen. I found a way with a small workaround.
Maybe this will help someone else who has issues setting up the training on GHEC. |
What is your repo visibility @edinc? We don't allow public which is what was breaking repo generation via the scripts for me. My fix was to create repos as internal for GHEC. Editing to add that I also needed to add logic to invite users to the org. Just need to get some time to do clean up before I can contribute my updates back. |
The repo visibility was Internal. I reopened the Issue, you can link it together with you contributions when you open a PR 😃 |
I'll try to get my changes pushed here in early December even if it's just a branch so you can test if my changes work for your GHEC instance as well. Taking a lot of year-end PTO, so no promises on timeframe. |
Hello,
Has anyone tried running the scripts to generate the repositories on an GHEC instance? I have an SSO account and a organisation (with Owner privileges), but somehow it still doesn't work.
I have created a PAT Token and authorised it for SAML single sign-on. Tried providing both
api.github.com
andgithub.com/enterprises/<customer-name>
in the.trainingmanualrc
file. When running the 'Confirm Setup' step, this is what I get:Is it even possible to run the scripts on GHEC or I need to follow the steps from the README regarding GitHub Enterprise Server?
The text was updated successfully, but these errors were encountered: