Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe-settings reapplies collaborator maintain permissions #636

Open
patrick-premont opened this issue May 29, 2024 · 1 comment
Open

Safe-settings reapplies collaborator maintain permissions #636

patrick-premont opened this issue May 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@patrick-premont
Copy link

Problem Description

The collaborator plugin reads the current permissions from the dict of booleans permissions and regenerates the permission string from it. But this logic only support 3 of the 5 built-in roles.

What is actually happening

This leads to safe-settings performing unnecessary updates when it processes repositories with collaborators that have the maintain role, for instance.

What is the expected behavior

All 5 built-in roles should be supported so that safe-setting only performs updates of collaboration permissions when necessary.

If it is exposed to the application, it would be preferable to read the permission field returned by GitHub directly. This would support all roles, including custom ones.

@patrick-premont patrick-premont added the bug Something isn't working label May 29, 2024
@shraddha761
Copy link

Assign this issue to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants