Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Schema Inaccuracy] merge-group schema description property isn't a valid OSA string #2609

Closed
WyriHaximus opened this issue Jun 13, 2023 · 2 comments

Comments

@WyriHaximus
Copy link

Schema Inaccuracy

   merge-group:
      type: object
      title: Merge Group
      description: 'A group of pull requests that the merge queue has grouped together
        to be merged.

'

Expected

    merge-group:
      type: object
      title: Merge Group
      description: 'A group of pull requests that the merge queue has grouped together to be merged.'

The PHP parser I'm using for this throws an exception when trying to parse it:

Fatal error: Uncaught Symfony\Component\Yaml\Exception\ParseException: Malformed inline YAML string at line 82925. in /__w/github-root/github-root/vendor/symfony/yaml/Parser.php:1152

This is currently present in the GitHub and GitHubEnterpriseCloud

WyriHaximus added a commit to php-api-clients/github-root that referenced this issue Jul 4, 2023
WyriHaximus added a commit to php-api-clients/github-root that referenced this issue Jul 4, 2023
Temporary patch broken spec files after download until github/rest-api-description#2609 has been resolved
@shiftkey shiftkey closed this as completed Sep 4, 2024
@shiftkey
Copy link
Member

shiftkey commented Sep 4, 2024

@WyriHaximus apologies for the delay on this. We've pushed a fix to resolve this issue in the schema, and identified another couple of places where this same problem is present, which should be fixed later today...

@WyriHaximus
Copy link
Author

Thank you for the update @shiftkey, managed to confirm this now works as expected and reverting the hotfixes that were applied each run: php-api-clients/github-root#1305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants