Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reserved identifier violation #31

Open
elfring opened this issue Aug 12, 2018 · 2 comments
Open

reserved identifier violation #31

elfring opened this issue Aug 12, 2018 · 2 comments

Comments

@elfring
Copy link

elfring commented Aug 12, 2018

I would like to point out that identifiers like “_GLB_DIRECTOR_CONFIG_H” and “__IPT_GLBREDIRECT_MATCH__” do not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?
@Akshit6828
Copy link

Akshit6828 commented May 4, 2021 •
edited
Loading

Hi @elfring. I got the issue. It means that we have to change the identifier's name as per the C language standard by not violating the naming conventions for reserved identifiers in C.

Am I correct?
If I am correct? Can I work on this issue?

Akshit6828 added a commit to Akshit6828/glb-director that referenced this issue May 4, 2021
@Akshit6828
FIX github#31 : Renamed indentifiers '_GLB_DIRECTOR_CONFIG_H' and '__…
438eedf 
…IPT_GLBREDIRECT_MATCH__' according to the naming conventions of C language.
@Akshit6828
Copy link

@elfring please review #122. Let me know if any updation required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elfring @Akshit6828