Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secret scanning alert matching logic for locations #1239

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dlinares-linux
Copy link

  • Reversed secret scanning location matching to loop through target locations instead of source locations. As mentioned in [gei] Secret scanning alert matching logic might need to be reversed for locations #1238, it is expected that this tool will be used at the back of a repo or org migration, and therefore, the number of alerts and number of locations for each alert at the source will always be greater or equal to the ones at the target as not everything gets migrated.
  • Fixed a secret scanning debug traces showing incorrect target alert number
  • Separated the logic doing the location matching into its own function.
  • Added 2 test cases to test the logic for location matching
  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

Fixes #1238

Copy link

github-actions bot commented May 3, 2024

Unit Test Results

812 tests   812 ✅  22s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit c76094a.

♻️ This comment has been updated with latest results.

@dlinares-linux dlinares-linux marked this pull request as ready for review May 3, 2024 12:06
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
bbs2gh 78% 73% 651
ado2gh 84% 78% 627
Octoshift 87% 76% 1270
gei 79% 70% 519
Summary 83% (6818 / 8169) 75% (1532 / 2042) 3067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gei] Secret scanning alert matching logic might need to be reversed for locations
2 participants