Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript: (CodeQL Customization) The Instance access path component does not match subclasses of the selected class #15999

Closed
mbaluda opened this issue Mar 20, 2024 · 3 comments
Assignees
Labels
JS question Further information is requested

Comments

@mbaluda
Copy link
Contributor

mbaluda commented Mar 20, 2024

Description of the issue

It should be possible to use the Instance access path component to match objects based on their abstract class

For example, it would allow accessing req in the following code

import cds from '@sap/cds'
class SampleVulnService extends cds.ApplicationService { init(){
  this.on ('submitOrder', async req => {
    const {book,quantity} = req.data

with the path

["@sap/cds",
 "Member[ApplicationService].Instance.Member[on].Argument[1].Parameter[0]", 
 "remote"]
@mbaluda mbaluda added the question Further information is requested label Mar 20, 2024
@mbaluda mbaluda changed the title JS MaD: the Instance access path component does match subclasses of the selected class JS MaD: the Instance access path component does not match subclasses of the selected class Mar 20, 2024
@sidshank sidshank added the JS label Mar 20, 2024
@sidshank sidshank changed the title JS MaD: the Instance access path component does not match subclasses of the selected class JavaScript: (CodeQL Customization) The Instance access path component does not match subclasses of the selected class Apr 2, 2024
@asgerf asgerf self-assigned this Apr 5, 2024
@asgerf
Copy link
Contributor

asgerf commented Apr 5, 2024

Draft PR in #16136

@asgerf
Copy link
Contributor

asgerf commented Apr 8, 2024

@mbaluda The above PR has been merged so I'm going to close the issue.

And thanks for the feedback! ✨ It's very valuable to have feedback like this to ensure we're making the right design choices in MaD.

@asgerf asgerf closed this as completed Apr 8, 2024
@mbaluda
Copy link
Contributor Author

mbaluda commented Apr 8, 2024

@asgerf that's wonderful! I'll test it ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JS question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants