C#: Relax dotnet rule.

github · Sep 30, 2024 · e8f244b · e8f244b
1 parent 6f74387
commit e8f244b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/csharp/autobuilder/Semmle.Autobuild.CSharp/DotNetRule.cs b/csharp/autobuilder/Semmle.Autobuild.CSharp/DotNetRule.cs
@@ -32,7 +32,7 @@ public BuildScript Analyse(IAutobuilder<CSharpAutobuildOptions> builder, bool au
                 NotDotNetProjects = builder.ProjectsOrSolutionsToBuild
                     .SelectMany(p => new[] { p }.Concat(p.IncludedProjects))
                     .OfType<Project<CSharpAutobuildOptions>>()
-                    .Where(p => !p.DotNetProject);
+                    .Where(p => !p.MaybeDotNetProject);
                 var notDotNetProject = NotDotNetProjects.FirstOrDefault();
 
                 if (notDotNetProject is not null)

diff --git a/csharp/autobuilder/Semmle.Autobuild.Shared/Project.cs b/csharp/autobuilder/Semmle.Autobuild.Shared/Project.cs
@@ -17,7 +17,7 @@ public class Project<TAutobuildOptions> : ProjectOrSolution<TAutobuildOptions> w
         /// <summary>
         /// Holds if this project is for .Net core.
         /// </summary>
-        public bool DotNetProject { get; private set; }
+        public bool MaybeDotNetProject { get; init; }
 
         public bool ValidToolsVersion { get; private set; }
 
@@ -32,7 +32,11 @@ public Project(Autobuilder<TAutobuildOptions> builder, string path) : base(build
             includedProjectsLazy = new Lazy<List<Project<TAutobuildOptions>>>(() => new List<Project<TAutobuildOptions>>());
 
             if (!builder.Actions.FileExists(FullPath))
+            {
+                // We can't out-rule that this is a dotnet project.
+                MaybeDotNetProject = true;
                 return;
+            }
 
             XmlDocument projFile;
             try
@@ -51,7 +55,7 @@ public Project(Autobuilder<TAutobuildOptions> builder, string path) : base(build
             {
                 if (root.HasAttribute("Sdk"))
                 {
-                    DotNetProject = true;
+                    MaybeDotNetProject = true;
                     return;
                 }