Skip to content

Commit b344795

Browse files
Match autoformatting, add QLDoc references
1 parent d371723 commit b344795

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

csharp/ql/src/Bad Practices/PathCombine.qhelp

+2
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
</recommendation>
1212
<references>
1313

14+
<li>Microsoft Learn, .NET API browser, <a href="https://learn.microsoft.com/en-us/dotnet/api/system.io.path.combine?view=net-9.0">Path.Combine</a>.</li>
15+
<li>Microsoft Learn, .NET API browser, <a href="https://learn.microsoft.com/en-us/dotnet/api/system.io.path.join?view=net-9.0">Path.Join</a>.</li>
1416

1517
</references>
1618
</qhelp>

csharp/ql/src/Bad Practices/PathCombine.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ import semmle.code.csharp.frameworks.System
1414

1515
from MethodCall call
1616
where call.getTarget().hasFullyQualifiedName("System.IO", "Path", "Combine")
17-
select call, "Path.Combine may silently discard its initial arguments if the latter are absolute paths. Use Path.Join to consistently join them."
17+
select call, "Call to System.IO.Path.Combine."
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
| PathCombine.cs:7:9:7:54 | call to method Combine | Path.Combine may silently discard its initial arguments if the latter are absolute paths. Use Path.Join to consistently join them. |
1+
| PathCombine.cs:7:9:7:54 | call to method Combine | Call to System.IO.Path.Combine. |

0 commit comments

Comments
 (0)