Apply suggestions from code review

Co-authored-by: Tom Hvitved <[email protected]>
github · Dec 11, 2024 · ad75906 · ad75906
1 parent 4b93325
commit ad75906
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/rust/ql/lib/codeql/rust/Concepts.qll b/rust/ql/lib/codeql/rust/Concepts.qll
@@ -179,15 +179,7 @@ module SqlSanitization {
 module Cryptography {
   private import codeql.rust.internal.ConceptsShared::Cryptography as SC
 
-  /**
-   * A data-flow node that is an application of a cryptographic algorithm. For example,
-   * encryption, decryption, signature-validation.
-   *
-   * Extend this class to refine existing API models. If you want to model new APIs,
-   * extend `CryptographicOperation::Range` instead.
-   */
-  class CryptographicOperation extends SC::CryptographicOperation instanceof CryptographicOperation::Range
-  { }
+  final class CryptographicOperation = SC:: CryptographicOperation;
 
   class EncryptionAlgorithm = SC::EncryptionAlgorithm;
 

diff --git a/rust/ql/lib/codeql/rust/frameworks/RustCrypto.qll b/rust/ql/lib/codeql/rust/frameworks/RustCrypto.qll
@@ -16,7 +16,7 @@ private string simplifyAlgorithmName(string algorithmName) {
  * An operation that initializes a cipher through the `cipher::KeyInit` or
  * `cipher::KeyIvInit` trait, for example `Des::new` or `cbc::Encryptor<des::Des>::new`.
  */
-class StreamCipherInit extends Cryptography::CryptographicOperation::Range, DataFlow::Node {
+class StreamCipherInit extends Cryptography::CryptographicOperation::Range {
   string algorithmName;
 
   StreamCipherInit() {