Fix poor performance of sameSource predicate

smowton · smowton · commit 985a2d1ed43a · 2025-06-04T12:28:41.000+01:00
diff --git a/cpp/common/src/codingstandards/cpp/rules/iofstreammissingpositioning/IOFstreamMissingPositioning.qll b/cpp/common/src/codingstandards/cpp/rules/iofstreammissingpositioning/IOFstreamMissingPositioning.qll
@@ -51,7 +51,8 @@ class WriteFunctionCall extends ReadWriteCall {
   }
 }
 
-pragma[inline]
+bindingset[a, b]
+pragma[inline_late]
 predicate sameSource(FunctionCall a, FunctionCall b) {
   sameStreamSource(a, b) or
   sameFileSource(a, b)

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,8 @@ class WriteFunctionCall extends ReadWriteCall {`
`51`	`51`	`}`
`52`	`52`	`}`
`53`	`53`
`54`		`-pragma[inline]`
	`54`	`+bindingset[a, b]`
	`55`	`+pragma[inline_late]`
`55`	`56`	`predicate sameSource(FunctionCall a, FunctionCall b) {`
`56`	`57`	`sameStreamSource(a, b) or`
`57`	`58`	`sameFileSource(a, b)`