Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit ead03f2

Browse files
committed
Stopped crash after publishing new repository
Visual Studio crashed after publishing, but the publishing process completed before the crash. A call was made to a disposed object after the view changed, causing the disposal.
1 parent f856aa8 commit ead03f2

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

src/GitHub.App/Controllers/UIController.cs

-1
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,6 @@ void End(bool success)
152152
{
153153
uiProvider.RemoveService(typeof(IConnection));
154154
transition.OnCompleted();
155-
completion?.OnNext(success);
156155
completion?.OnCompleted();
157156
completion = null;
158157
}

src/GitHub.VisualStudio/TeamExplorer/Sync/GitHubPublishSection.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ void ShowPublish()
117117
disposable = uiflow;
118118
var ui = uiflow.Value;
119119
var creation = ui.SelectFlow(UIControllerFlow.Publish);
120-
ui.ListenToCompletionState().Subscribe(done =>
120+
ui.ListenToCompletionState().Subscribe(_ => { }, () =>
121121
{
122122
IsVisible = false;
123123
ServiceProvider.TryGetService<ITeamExplorer>()?.NavigateToPage(new Guid(TeamExplorerPageIds.Home), null);

0 commit comments

Comments
 (0)