Add using to avoid crash in Release mode

jcansdale · jcansdale · commit e25391af9b04 · 2017-11-21T10:53:16.000Z
Somehow putting the `repo` object in a `using` avoids the following issue: #1306
diff --git a/src/GitHub.App/Services/PullRequestService.cs b/src/GitHub.App/Services/PullRequestService.cs
@@ -88,8 +88,12 @@ public IObservable<string> GetPullRequestTemplate(ILocalRepositoryModel reposito
 
         public IObservable<bool> IsWorkingDirectoryClean(ILocalRepositoryModel repository)
         {
-            var repo = gitService.GetRepository(repository.LocalPath);
-            return Observable.Return(!repo.RetrieveStatus().IsDirty);
+            // The `using` appears to resolve this issue:
+            // https://github.com/github/VisualStudio/issues/1306
+            using (var repo = gitService.GetRepository(repository.LocalPath))
+            {
+                return Observable.Return(!repo.RetrieveStatus().IsDirty);
+            }
         }
 
         public IObservable<Unit> Pull(ILocalRepositoryModel repository)

Original file line number	Diff line number	Diff line change
`@@ -88,8 +88,12 @@ public IObservable<string> GetPullRequestTemplate(ILocalRepositoryModel reposito`
`88`	`88`
`89`	`89`	`public IObservable<bool> IsWorkingDirectoryClean(ILocalRepositoryModel repository)`
`90`	`90`	`{`
`91`		`- var repo = gitService.GetRepository(repository.LocalPath);`
`92`		`- return Observable.Return(!repo.RetrieveStatus().IsDirty);`
	`91`	+ // The `using` appears to resolve this issue:
	`92`	`+ // https://github.com/github/VisualStudio/issues/1306`
	`93`	`+ using (var repo = gitService.GetRepository(repository.LocalPath))`
	`94`	`+ {`
	`95`	`+ return Observable.Return(!repo.RetrieveStatus().IsDirty);`
	`96`	`+ }`
`93`	`97`	`}`
`94`	`98`
`95`	`99`	`public IObservable<Unit> Pull(ILocalRepositoryModel repository)`