Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit db64eaf

Browse files
authored
Merge branch 'master' into feature/gist-support
2 parents f029180 + 5b466de commit db64eaf

File tree

7 files changed

+30
-143
lines changed

7 files changed

+30
-143
lines changed

CONTRIBUTING.md

+25-1
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,33 @@ There are certain areas of the extension that are restricted in what they can do
3131
- Team Explorer content outside the Home page is slightly less restricted, but not by much
3232
- Dialogs and views that don't inherit from TeamExplorer classes are free to use what they need.
3333

34+
## Submitting an Issue
35+
36+
### Bug Reporting
37+
38+
Here are a few helpful tips when reporting a bug:
39+
- Verify the bug resides in the GitHub for Visual Studio extension
40+
- A lot of functionality provided by this extension resides in the Team Explorer pane, alongside other non-GitHub tools to manage and collaborate on source code, including Visual Studio's Git support, which is owned by Microsoft.
41+
- If this bug not is related to the GitHub extension, visit the [Visual Studio support page](https://www.visualstudio.com/support/support-overview-vs) for help
42+
- Screenshots are very helpful in diagnosing bugs and understanding the state of the extension when it's experiencing problems. Please include them whenever possible.
43+
- A log file is helpful in diagnosing bug issues. To include log files in your issue:
44+
45+
1. Close Visual Studio if it's open
46+
2. Open a Developer Command Prompt for VS2015
47+
3. Run devenv /log
48+
4. Reproduce your issue
49+
5. Close VS
50+
6. Locate the following files on your system and email them to [email protected] or create a gist and link it in the issue report:
51+
- `%appdata%\Microsoft\VisualStudio\14.0\ActivityLog.xml`
52+
- `%localappdata%\temp\extension.log`
53+
- `%localappdata%\GitHubVisualStudio\extension.log`
54+
55+
### Feature Requests
56+
If you have a feature that you think would be a great addition to the extension, we might already have thought about it too, so be sure to check if your suggestion matches our [roadmap](#roadmap-and-future-feature-ideas) before making a request. Also take a peek at our [pull requests](https://github.com/github/VisualStudio/pulls) to see what we're currently working on. Additionally, someone might have already thought of your idea, so check out Issues labeled as [features](https://github.com/github/VisualStudio/issues?q=is%3Aopen+is%3Aissue+label%3Afeature) to see if it already exists.
57+
3458
## Things to improve in the current version
3559

36-
- Localization
60+
- [Localization](https://github.com/github/VisualStudio/issues/18)
3761

3862
## Roadmap and future feature ideas
3963

src/GitHub.App/SampleData/SampleViewModels.cs

-8
Original file line numberDiff line numberDiff line change
@@ -232,14 +232,6 @@ public RepositoryPublishViewModelDesigner()
232232
SelectedConnection = Connections[0];
233233
}
234234

235-
public string DefaultRepositoryName
236-
{
237-
get
238-
{
239-
return "whatever";
240-
}
241-
}
242-
243235
public bool IsHostComboBoxVisible
244236
{
245237
get

src/GitHub.App/ViewModels/RepositoryPublishViewModel.cs

+1-2
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public RepositoryPublishViewModel(
9191

9292
var defaultRepositoryName = repositoryPublishService.LocalRepositoryName;
9393
if (!string.IsNullOrEmpty(defaultRepositoryName))
94-
DefaultRepositoryName = defaultRepositoryName;
94+
RepositoryName = defaultRepositoryName;
9595

9696
this.WhenAny(x => x.SelectedConnection, x => x.SelectedAccount,
9797
(a,b) => true)
@@ -106,7 +106,6 @@ public RepositoryPublishViewModel(
106106
});
107107
}
108108

109-
public string DefaultRepositoryName { get; private set; }
110109
public new string Title { get { return title.Value; } }
111110
public bool CanKeepPrivate { get { return canKeepPrivate.Value; } }
112111
public bool IsPublishing { get { return isPublishing.Value; } }

src/GitHub.Exports.Reactive/ViewModels/IRepositoryPublishViewModel.cs

-5
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,6 @@ public interface IRepositoryPublishViewModel : IRepositoryForm
2828
/// The selected host to publish to.
2929
/// </summary>
3030
IConnection SelectedConnection { get; set; }
31-
32-
/// <summary>
33-
/// Sets the default repository name when prepopulating the form.
34-
/// </summary>
35-
string DefaultRepositoryName { get; }
3631
}
3732

3833
public enum ProgressState

src/GitHub.VisualStudio/GitHub.VisualStudio.vsct

+4-4
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@
9090
<CommandFlag>IconIsMoniker</CommandFlag>
9191
<CommandFlag>DefaultDisabled</CommandFlag>
9292
<Strings>
93-
<ButtonText></ButtonText>
93+
<ButtonText>Back</ButtonText>
9494
</Strings>
9595
</Button>
9696

@@ -99,7 +99,7 @@
9999
<CommandFlag>IconIsMoniker</CommandFlag>
100100
<CommandFlag>DefaultDisabled</CommandFlag>
101101
<Strings>
102-
<ButtonText></ButtonText>
102+
<ButtonText>Forward</ButtonText>
103103
</Strings>
104104
</Button>
105105

@@ -108,7 +108,7 @@
108108
<CommandFlag>IconIsMoniker</CommandFlag>
109109
<CommandFlag>DefaultDisabled</CommandFlag>
110110
<Strings>
111-
<ButtonText></ButtonText>
111+
<ButtonText>Pull Requests</ButtonText>
112112
</Strings>
113113
</Button>
114114

@@ -117,7 +117,7 @@
117117
<CommandFlag>IconIsMoniker</CommandFlag>
118118
<CommandFlag>DefaultDisabled</CommandFlag>
119119
<Strings>
120-
<ButtonText></ButtonText>
120+
<ButtonText>Refresh</ButtonText>
121121
</Strings>
122122
</Button>
123123

src/GitHub.VisualStudio/Helpers/SharedDictionaryManager.cs

-121
This file was deleted.

src/GitHub.VisualStudio/UI/Views/Controls/RepositoryPublishControl.xaml.cs

-2
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,6 @@ public RepositoryPublishControl(ITeamExplorerServices teServices, INotificationD
5757
else
5858
teServices.ClearNotifications();
5959
}));
60-
61-
nameText.Text = ViewModel.DefaultRepositoryName;
6260
});
6361
IsVisibleChanged += (s, e) =>
6462
{

0 commit comments

Comments
 (0)