Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 95256e3

Browse files
Jasminepaladique
Jasmine
authored andcommitted
move strings in xaml files to resx
1 parent 95b1264 commit 95256e3

File tree

4 files changed

+56
-7
lines changed

4 files changed

+56
-7
lines changed

src/GitHub.VisualStudio.UI/Resources.Designer.cs

Lines changed: 36 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/GitHub.VisualStudio.UI/Resources.resx

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,9 +132,6 @@
132132
<data name="browsePathButtonContent" xml:space="preserve">
133133
<value>Browse</value>
134134
</data>
135-
<data name="GetStartedLink" xml:space="preserve">
136-
<value>Get Started</value>
137-
</data>
138135
<data name="couldNotConnectToGitHubText" xml:space="preserve">
139136
<value>Could not connect to github.com</value>
140137
</data>
@@ -330,4 +327,19 @@
330327
<data name="NotAGitRepositoryMessage" xml:space="preserve">
331328
<value>We couldn't find a git repository here. Open a git project or click "File -&gt; Add to Source Control" in a project to get started.</value>
332329
</data>
330+
<data name="CreateAccountLink" xml:space="preserve">
331+
<value>Create an account</value>
332+
</data>
333+
<data name="filterBranchesText" xml:space="preserve">
334+
<value>Filter branches</value>
335+
</data>
336+
<data name="GetStartedLink" xml:space="preserve">
337+
<value>Get Started</value>
338+
</data>
339+
<data name="GetStartedText" xml:space="preserve">
340+
<value>Get Started</value>
341+
</data>
342+
<data name="SignInLink" xml:space="preserve">
343+
<value>Sign In</value>
344+
</data>
333345
</root>

src/GitHub.VisualStudio/UI/Views/LoggedOutView.xaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
xmlns:local="clr-namespace:GitHub.VisualStudio.UI.Views"
77
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
88
xmlns:sampleData="clr-namespace:GitHub.SampleData;assembly=GitHub.App"
9+
xmlns:prop="clr-namespace:GitHub.VisualStudio.UI;assembly=GitHub.VisualStudio.UI"
910
xmlns:ui="clr-namespace:GitHub.UI;assembly=GitHub.UI"
1011
DataContext="{Binding ViewModel}"
1112
d:DesignHeight="300"
@@ -52,13 +53,13 @@
5253
<TextBlock
5354
Margin="10,0"
5455
HorizontalAlignment="Center">
55-
<Hyperlink Command="{Binding SignIn}">Sign in</Hyperlink>
56+
<Hyperlink Command="{Binding SignIn}"><TextBlock Text="{x:Static prop:Resources.SignInLink}"/></Hyperlink>
5657
</TextBlock>
5758

5859
<TextBlock
5960
Margin="10,0"
6061
HorizontalAlignment="Center">
61-
<Hyperlink Command="{Binding Register}">Create an account</Hyperlink>
62+
<Hyperlink Command="{Binding Register}"><TextBlock Text="{x:Static prop:Resources.CreateAccountLink}"/></Hyperlink>
6263
</TextBlock>
6364
</StackPanel>
6465
</StackPanel>

src/GitHub.VisualStudio/UI/Views/NotAGitHubRepositoryView.xaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@
4141
<Button HorizontalAlignment="Center"
4242
Margin="0,15"
4343
Style="{DynamicResource GitHubVsPrimaryActionButton}"
44-
Command="{Binding Publish}">
45-
Get Started
44+
Command="{Binding Publish}" >
45+
<TextBlock Text="{x:Static prop:Resources.GetStartedText}" />
4646
</Button>
4747
</StackPanel>
4848
</DockPanel>

0 commit comments

Comments
 (0)