Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong color for haskell #3727

Closed
adius opened this issue Jul 22, 2017 · 11 comments · Fixed by #3728
Closed

Wrong color for haskell #3727

adius opened this issue Jul 22, 2017 · 11 comments · Fixed by #3728
Assignees

Comments

@adius
Copy link

adius commented Jul 22, 2017

The haskell community has obviously settled with purple (check out https://haskell.org, https://haskell-lang.org, https://reddit.com/r/haskell, ...). rgb(94,80,134) to be precise.
At the moment GitHub, however, uses green. This should be changed.

@Alhadis
Copy link
Collaborator

Alhadis commented Jul 22, 2017

We like green. Go away.

Kidding. No, you're right, this should certainly be updated. Though HaskellWiki says DarkBlue, but from the looks of things, I'd say that's outdated.

@Alhadis
Copy link
Collaborator

Alhadis commented Jul 22, 2017

All done! See #3728. If you're very lucky, this might even be included in the about-to-be-shipped release of Linguist (meaning it'll take effect on GitHub very shortly after approval).

@adius
Copy link
Author

adius commented Jul 22, 2017

Nice! I was preparing for a day long argument 😂, but cool to see that decisions can actually be made quickly.
There just one thing to clarify: I just realized that it's actually a gradient between rgb(79, 67, 113) and rgb(110, 93, 157) and not a solid color.
So I'm not sure which color should actually be used...
I guess the brighter one?

@Alhadis
Copy link
Collaborator

Alhadis commented Jul 22, 2017

Hold on, is this based on an official styleguide? You said "rgb(94,80,134) to be precise", which lead me to believe this was being drawn from concrete branding guidelines...

Do you have a link to the official palette perchance?

@adius
Copy link
Author

adius commented Jul 22, 2017

Sorry, I was maybe a little exuberant with my language. I was looking for a style guide, but there is none. The most official it gets ist the official logo used on haskell.org: https://github.com/haskell-infra/hl/blob/master/design/logo.svg
I just erroneously used a color picker instead of checking the source, which didn't work as expected as it had a gradient. 🙈

@Alhadis
Copy link
Collaborator

Alhadis commented Jul 22, 2017

When looking for colour choices, I always start with the logo's palette. =)

It's clear that the colour needs to be changed... heck, even Haskell's boring old logo used purple!

oldhaskelllogo

From the colours used in the Haskell site's SVG logo, I'd say #5e5086 (sampled from the centre lambda) is probably the best pick. Which is the same shade as the one you've chosen, so... no change necessary.

... there's also no gradient. :o

@adius
Copy link
Author

adius commented Jul 22, 2017

there's also no gradient

Now I'm really confused. The link I send you is supposed to be the source code for the haskell.org website. So it should be the same file as the link you posted, but obviously it's not 😳

... oh, I see. They have 2 logos in their source code:

and they are slightly different 😭 ... what a fail. I'll open a pull request.

Long story short let's stick with #5e5086 👍

@Alhadis
Copy link
Collaborator

Alhadis commented Jul 22, 2017

I'm colourblind anyway, so everything that's been mentioned so far looks the same shade of purple to, lel.

@adius
Copy link
Author

adius commented Jul 22, 2017

Unification of logos issue: haskell-infra/hl#215

@Alhadis
Copy link
Collaborator

Alhadis commented Jul 22, 2017

They won't do anything about it.

Haskell is lazy, remember?

kek

(I probably shouldn't review stuff while sleep-deprived, but hey, hopefully we're all having fun here...)

@chrisdone
Copy link

Cool! The theme was my theme, but based on Haskell's much older purple logo anyway.

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants