From c965e817261e484b9b623398a6b685a8a5bdd06a Mon Sep 17 00:00:00 2001 From: Andreia Gaita Date: Fri, 1 Sep 2017 14:13:35 +0200 Subject: [PATCH 1/3] Move extension installation location to Assets/Plugins/GitHub --- README.md | 2 +- build.cmd | 38 +++++++++---------- build.sh | 34 ++++++++--------- common/packaging.targets | 4 +- package.cmd | 8 ++-- package.sh | 10 ++--- src/GitHub.Api/Resources/.gitignore | 4 +- .../Editor/GitHub.Unity/GitHub.Unity.csproj | 2 +- unity/PackageProject/.gitignore | 8 ++-- unity/PackageProject/Assets/Plugins.meta | 9 +++++ .../Assets/{ => Plugins}/GitHub.meta | 0 .../Assets/{ => Plugins}/GitHub/Editor.meta | 0 .../GitHub/Editor/AsyncBridge.Net35.dll.meta | 0 .../GitHub/Editor/CREDITS.txt.meta | 0 .../{ => Plugins}/GitHub/Editor/EULA.txt.meta | 0 .../GitHub/Editor/GitHub.Api.dll.mdb.meta | 0 .../GitHub/Editor/GitHub.Api.dll.meta | 0 .../GitHub/Editor/GitHub.Logging.dll.mdb.meta | 0 .../GitHub/Editor/GitHub.Logging.dll.meta | 0 .../Editor/ICSharpCode.SharpZipLib.dll.meta | 0 .../GitHub/Editor/Mono.Posix.dll.meta | 0 .../GitHub/Editor/Mono.Security.dll.meta | 0 .../GitHub/Editor/Octokit.dll.meta | 0 .../GitHub/Editor/PlatformResources.meta | 0 .../GitHub/Editor/PlatformResources/mac.meta | 0 .../PlatformResources/mac/git-lfs.zip.meta | 0 .../Editor/PlatformResources/windows.meta | 0 .../windows/git-lfs.zip.meta | 0 .../PlatformResources/windows/git.zip.meta | 0 .../Editor/Rackspace.Threading.dll.meta | 0 .../ReadOnlyCollectionsInterfaces.dll.meta | 0 .../GitHub/Editor/System.Net.Http.dll.meta | 0 .../GitHub/Editor/System.Threading.dll.meta | 0 .../GitHub/Editor/sfw.net.dll.meta | 0 .../{ => Plugins}/GitHub/Editor/x64.meta | 0 .../{ => Plugins}/GitHub/Editor/x86.meta | 0 36 files changed, 64 insertions(+), 55 deletions(-) create mode 100644 unity/PackageProject/Assets/Plugins.meta rename unity/PackageProject/Assets/{ => Plugins}/GitHub.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/AsyncBridge.Net35.dll.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/CREDITS.txt.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/EULA.txt.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/GitHub.Api.dll.mdb.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/GitHub.Api.dll.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/GitHub.Logging.dll.mdb.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/GitHub.Logging.dll.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/ICSharpCode.SharpZipLib.dll.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/Mono.Posix.dll.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/Mono.Security.dll.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/Octokit.dll.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/PlatformResources.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/PlatformResources/mac.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/PlatformResources/mac/git-lfs.zip.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/PlatformResources/windows.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/PlatformResources/windows/git-lfs.zip.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/PlatformResources/windows/git.zip.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/Rackspace.Threading.dll.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/ReadOnlyCollectionsInterfaces.dll.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/System.Net.Http.dll.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/System.Threading.dll.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/sfw.net.dll.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/x64.meta (100%) rename unity/PackageProject/Assets/{ => Plugins}/GitHub/Editor/x86.meta (100%) diff --git a/README.md b/README.md index 70912fa86..2e8d129dd 100644 --- a/README.md +++ b/README.md @@ -2,7 +2,7 @@ ## Notices -From version 0.19 onwards, the location of the plugin has moved to `Assets/GitHub`. If you have version 0.18 or lower, you need to delete the `Assets/Editor/GitHub` folder before you install newer versions. You should exit Unity and delete the folder from Explorer/Finder, as Unity will not unload native libraries while it's running. +From version 0.19 onwards, the location of the plugin has moved to `Assets/Plugins/GitHub`. If you have version 0.18 or lower, you need to delete the `Assets/Editor/GitHub` folder before you install newer versions. You should exit Unity and delete the folder from Explorer/Finder, as Unity will not unload native libraries while it's running. ![Build Status](https://ci.appveyor.com/api/projects/status/github/github-for-unity/Unity?branch=master&svg=true) diff --git a/build.cmd b/build.cmd index f0e84b7c3..af6f8fab7 100644 --- a/build.cmd +++ b/build.cmd @@ -12,14 +12,14 @@ if not %2.==. ( ) if %Target%==Rebuild ( - del /Q unity\PackageProject\Assets\GitHub\Editor\*.dll - del /Q unity\PackageProject\Assets\GitHub\Editor\*.mdb - del /Q unity\PackageProject\Assets\GitHub\Editor\*.pdb - - if exist "..\github-unity-test\GitHubExtensionProject\Assets\GitHub\Editor" ( - del /Q ..\github-unity-test\GitHubExtensionProject\Assets\GitHub\Editor\*.dll - del /Q ..\github-unity-test\GitHubExtensionProject\Assets\GitHub\Editor\*.mdb - del /Q ..\github-unity-test\GitHubExtensionProject\Assets\GitHub\Editor\*.pdb + del /Q unity\PackageProject\Assets\Plugins\GitHub\Editor\*.dll + del /Q unity\PackageProject\Assets\Plugins\GitHub\Editor\*.mdb + del /Q unity\PackageProject\Assets\Plugins\GitHub\Editor\*.pdb + + if exist "..\github-unity-test\GitHubExtensionProject\Assets\Plugins\GitHub\Editor" ( + del /Q ..\github-unity-test\GitHubExtensionProject\Assets\Plugins\GitHub\Editor\*.dll + del /Q ..\github-unity-test\GitHubExtensionProject\Assets\Plugins\GitHub\Editor\*.mdb + del /Q ..\github-unity-test\GitHubExtensionProject\Assets\Plugins\GitHub\Editor\*.pdb ) ) @@ -28,18 +28,18 @@ call common\nuget.exe restore GitHub.Unity.sln echo xbuild GitHub.Unity.sln /verbosity:normal /property:Configuration=%Configuration% /target:%Target% call xbuild GitHub.Unity.sln /verbosity:normal /property:Configuration=%Configuration% /target:%Target% -del /Q unity\PackageProject\Assets\GitHub\Editor\deleteme* -del /Q unity\PackageProject\Assets\GitHub\Editor\deleteme* -del /Q unity\PackageProject\Assets\GitHub\Editor\*.xml +del /Q unity\PackageProject\Assets\Plugins\GitHub\Editor\deleteme* +del /Q unity\PackageProject\Assets\Plugins\GitHub\Editor\deleteme* +del /Q unity\PackageProject\Assets\Plugins\GitHub\Editor\*.xml -echo xcopy /C /H /R /S /Y /Q unity\PackageProject\Assets\GitHub ..\github-unity-test\GitHubExtensionProject\Assets\ -call xcopy /C /H /R /S /Y /Q unity\PackageProject\Assets\GitHub ..\github-unity-test\GitHubExtensionProject\Assets\ +echo xcopy /C /H /R /S /Y /Q unity\PackageProject\Assets\Plugins\GitHub ..\github-unity-test\GitHubExtensionProject\Assets\Plugins\ +call xcopy /C /H /R /S /Y /Q unity\PackageProject\Assets\Plugins\GitHub ..\github-unity-test\GitHubExtensionProject\Assets\Plugins\ -echo xcopy /C /H /R /Y /Q unity\PackageProject\Assets\GitHub.meta ..\github-unity-test\GitHubExtensionProject\Assets\ -call xcopy /C /H /R /Y /Q unity\PackageProject\Assets\GitHub.meta ..\github-unity-test\GitHubExtensionProject\Assets\ +echo xcopy /C /H /R /Y /Q unity\PackageProject\Assets\Plugins\GitHub.meta ..\github-unity-test\GitHubExtensionProject\Assets\Plugins\ +call xcopy /C /H /R /Y /Q unity\PackageProject\Assets\Plugins\GitHub.meta ..\github-unity-test\GitHubExtensionProject\Assets\Plugins\ -if exist ..\github-unity-test\GitHubExtensionProject\Assets\GitHub\Editor ( - del /Q ..\github-unity-test\GitHubExtensionProject\Assets\GitHub\Editor\deleteme* - del /Q ..\github-unity-test\GitHubExtensionProject\Assets\GitHub\Editor\deleteme* - del /Q ..\github-unity-test\GitHubExtensionProject\Assets\GitHub\Editor\*.xml +if exist ..\github-unity-test\GitHubExtensionProject\Assets\Plugins\GitHub\Editor ( + del /Q ..\github-unity-test\GitHubExtensionProject\Assets\Plugins\GitHub\Editor\deleteme* + del /Q ..\github-unity-test\GitHubExtensionProject\Assets\Plugins\GitHub\Editor\deleteme* + del /Q ..\github-unity-test\GitHubExtensionProject\Assets\Plugins\GitHub\Editor\*.xml ) \ No newline at end of file diff --git a/build.sh b/build.sh index 88ecf8afd..fd10a474d 100755 --- a/build.sh +++ b/build.sh @@ -10,14 +10,14 @@ if [ $# -gt 1 ]; then fi if [ x"$Target" == x"Rebuild" ]; then - rm -f unity/PackageProject/Assets/GitHub/Editor/*.dll - rm -f unity/PackageProject/Assets/GitHub/Editor/*.mdb - rm -f unity/PackageProject/Assets/GitHub/Editor/*.pdb - - if [ -e ../github-unity-test/GitHubExtensionProject/Assets/GitHub/Editor ]; then - rm -f ../github-unity-test/GitHubExtensionProject/Assets/GitHub/Editor/*.dll - rm -f ../github-unity-test/GitHubExtensionProject/Assets/GitHub/Editor/*.mdb - rm -f ../github-unity-test/GitHubExtensionProject/Assets/GitHub/Editor/*.pdb + rm -f unity/PackageProject/Assets/Plugins/GitHub/Editor/*.dll + rm -f unity/PackageProject/Assets/Plugins/GitHub/Editor/*.mdb + rm -f unity/PackageProject/Assets/Plugins/GitHub/Editor/*.pdb + + if [ -e ../github-unity-test/GitHubExtensionProject/Assets/Plugins/GitHub/Editor ]; then + rm -f ../github-unity-test/GitHubExtensionProject/Assets/Plugins/GitHub/Editor/*.dll + rm -f ../github-unity-test/GitHubExtensionProject/Assets/Plugins/GitHub/Editor/*.mdb + rm -f ../github-unity-test/GitHubExtensionProject/Assets/Plugins/GitHub/Editor/*.pdb fi fi @@ -34,16 +34,16 @@ fi xbuild GitHub.Unity.sln /verbosity:normal /property:Configuration=$Configuration /target:$Target || true -rm -f unity/PackageProject/Assets/GitHub/Editor/deleteme* -rm -f unity/PackageProject/Assets/GitHub/Editor/deleteme* -rm -f unity/PackageProject/Assets/GitHub/Editor/*.xml +rm -f unity/PackageProject/Assets/Plugins/GitHub/Editor/deleteme* +rm -f unity/PackageProject/Assets/Plugins/GitHub/Editor/deleteme* +rm -f unity/PackageProject/Assets/Plugins/GitHub/Editor/*.xml -cp -r unity/PackageProject/Assets/GitHub ../github-unity-test/GitHubExtensionProject/Assets/ || true -cp -r unity/PackageProject/Assets/GitHub.meta ../github-unity-test/GitHubExtensionProject/Assets/ || true +cp -r unity/PackageProject/Assets/Plugins/GitHub ../github-unity-test/GitHubExtensionProject/Assets/Plugins/ || true +cp -r unity/PackageProject/Assets/Plugins/GitHub.meta ../github-unity-test/GitHubExtensionProject/Assets/Plugins/ || true -if [ -e ../github-unity-test/GitHubExtensionProject/Assets/GitHub/Editor ]; then - rm -f ../github-unity-test/GitHubExtensionProject/Assets/GitHub/Editor/deleteme* - rm -f ../github-unity-test/GitHubExtensionProject/Assets/GitHub/Editor/deleteme* - rm -f ../github-unity-test/GitHubExtensionProject/Assets/GitHub/Editor/*.xml +if [ -e ../github-unity-test/GitHubExtensionProject/Assets/Plugins/GitHub/Editor ]; then + rm -f ../github-unity-test/GitHubExtensionProject/Assets/Plugins/GitHub/Editor/deleteme* + rm -f ../github-unity-test/GitHubExtensionProject/Assets/Plugins/GitHub/Editor/deleteme* + rm -f ../github-unity-test/GitHubExtensionProject/Assets/Plugins/GitHub/Editor/*.xml fi \ No newline at end of file diff --git a/common/packaging.targets b/common/packaging.targets index 445c770d0..77f866e20 100644 --- a/common/packaging.targets +++ b/common/packaging.targets @@ -2,8 +2,8 @@ - $(SolutionDir)\unity\PackageProject\Assets\GitHub\Editor - $(SolutionDir)..\github-unity-test\GitHubExtensionProject\Assets\GitHub\Editor + $(SolutionDir)\unity\PackageProject\Assets\Plugins\GitHub\Editor + $(SolutionDir)..\github-unity-test\GitHubExtensionProject\Assets\Plugins\GitHub\Editor