-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to add gradient fill to shapes? #102
Comments
Hi @sangramjagtap , Thanks for the question/issue. The library does support gradients as of yet. I've added this to the enhancement list. |
Thanks for the clarification.
…On Wed, Jun 21, 2017 at 8:24 AM, Brent Ely ***@***.***> wrote:
Hi @sangramjagtap <https://github.com/sangramjagtap> ,
Thanks for the question/issue.
The library does support gradients as of yet. I've added this to the
enhancement list.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#102 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ARCCHKHgUd-ng9TKjjU6ZLkW5dEaB6miks5sGIXngaJpZM4N69Ru>
.
--
Thanks & Regards,
Sangram M. Jagtap
Email: [email protected] <[email protected]>
Phone: +91 844 644 6043
Skype: sangramjagtap7
|
fyi - I've implemented this. I'll open up a PR when I get a chance. Here's an example showing the fill on a slide master as the background.
The way it's implemented, it works on both slide masters and also slide shapes that currently support the 'fill' option, e.g. images and text. The way the background is currently implemented in slide masters means it would be awfully hard to have both an image and also a fill. That threw me for a while until I realized basically there is no need to specify a background image - just specify fill as the background and then add an image that fills the entire slide. |
@gitbrent you open to a PR on this? if so, anything you're looking for in particular in a PR? |
Hi @pstoll, Absolutely, PR's are always welcome. Content-wise:
|
Hi @pstoll ! You said you implemented this and wanted to open PR. Unfortunately still no PR here 😢. Do you want some help ? We could try to open the PR with you if you want because we need this feature too 😄 Have a great day ! |
Any news about that ? |
Sorry, lost track of this. Let me see if I can dig this up. |
Thanks, and so ? :D |
Hi @pstoll, |
Hello @pstoll, |
The same, need to set gradient to slides |
Hi All, It appears Perry hasn't been on GitHub for awhile and the clone he made of the repo was never patched for gradient support. As the community is interested in this, i've tagged it for triage so i can scope what needs to be coded to support this functionality. I'll circle back after |
Hi, |
I have an almost complete gradient implementation that I'll submit a PR for. It's functional and supports linear, radial, rectangular, and path gradients. |
@ReimaFrgos hey, any news on this ? I saw your branch https://github.com/ReimaFrgos/PptxGenJS/tree/92+103-AddGradientSupport there is nothing on it yet, do you need a hand ? |
@ReimaFrgos @hilnius I have a partial solution, I would like to help with the issue |
Hello, this is my first github post so please excuse me if I break protocol. Unless I am mistaken the gradient feature still does not seem to be implemented. Is it still being worked on and or investigated? Thank you. |
Hi! Thanks :) |
I've pushed this PR if people are interested. I have only done one implementation in the demo suite and haven't modified the docs. If anyone want's to contribute to the PR for those then please go ahead. #1295 This could potentially be used to add gradients to slide backgrounds and object outlines as well. |
@sambauers: I noticed your PR related to the gradient solution for demo purposes. Do you happen to have a more complete solution, or have you made further progress on it since then? Any updates would be greatly appreciated! |
No, sorry I haven’t touched it since then. I moved on to a different library for PPTX generation. |
This is sample slide which I'm trying to export using PptxGenJS
How to add gradient fill to shapes?
The text was updated successfully, but these errors were encountered: