-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We forked this package and have fixed many bugs #47
Comments
Hi @alexeyinkin, just see this and your previous issue #38. Thanks for the work to improve it!
As you said, I really don't have much time to maintain this package at the moment, so I also think it's a more appropriate choice to hand it over to a team that has enough time to maintain it. Considering the existing users, perhaps I can add you and your coworkers as admin (for both GitHub repo and pub.dev package), and you can directly use this package name. Then existing users do not need to do additional migration work, they just need to upgrade the version. What do you think? |
@pd4d10 this would be awesome! For pub.dev, please add Regarding GitHub, we would rather maintain our own fork because we have a history there. What we can do in this repository is write in the README.md an encouragement to migrate and all the new links. For that, please make me an admin (or whatever it is called on GitHub). |
Not quite sure about what you mean, I guess a simple If you're concerned about the organization name, maybe we can move this repo to a new organization, such as something like "highlight-dart", just like @highlightjs does. What do you think? |
OK. My employer would want it under their https://github.com/akvelon organization. Please transfer it there. |
OK. Personally, I prefer it to be maintained by the community, but I also fully understand your request, if these work were done during the time working for the company. Please give me some time to consider it. Anyway, thanks very much for your work to improve it! |
@pd4d10 can you add me on LinkedIn? https://www.linkedin.com/in/alexey-inkin-784b7371/ |
@alexeyinkin Now that you are no longer working for Akvelon, can you update us about the status of flutter_highlighting? Is there a commitment to maintain it (by who)? |
In Akvelon, @nausharipov is now in charge of Flutter. If anyone knows the roadmap, it is him. |
Would you adopt this PR? |
@busslina, yes. Thank you. I've replied here: akvelon/dart-highlighting#74 (comment) |
A year later, the fork appears to be abandoned 🫤 |
This project seems abandoned, so we forked it and did the following:
Language
class in addition toMode
to better mimic the original HighlightJS classes.The new package is published as:
We intend to maintain our fork.
See the migration guide: https://github.com/akvelon/dart-highlighting/blob/main/doc/migrating.md
(Posting this here as there seems to be no other way to inform the users of the package who are in need of changes.)
The text was updated successfully, but these errors were encountered: